Fix NameError when pydot is not installed in Beam Playground#38074
Fix NameError when pydot is not installed in Beam Playground#38074liferoad wants to merge 1 commit intoapache:masterfrom
Conversation
When pydot is not installed, the import in pipeline_graph.py fails silently (caught by 'except ImportError: pass'), and subsequent calls to pydot.Dot() raise a confusing NameError with no context. Now _construct_graph() checks if pydot is available before use and raises a clear RuntimeError with install instructions instead. Fixes apache#37829
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the error handling in the Beam Playground's pipeline graph generation. By explicitly checking for the presence of the pydot dependency, it prevents confusing runtime errors and provides actionable feedback to users when the library is missing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
What
When pydot is not installed, the import in pipeline_graph.py fails silently (caught by except ImportError: pass), and subsequent calls to pydot.Dot() raise a confusing NameError with no context about what is missing or how to fix it.
How
_construct_graph() now checks if pydot is available before use and raises a clear RuntimeError with install instructions instead.
Testing
Manually verified the fix works by importing the module with and without pydot installed.
Fixes #37829