Skip to content

Fix NameError when pydot is not installed in Beam Playground#38074

Open
liferoad wants to merge 1 commit intoapache:masterfrom
liferoad:fix/pydot-nameerror-playground
Open

Fix NameError when pydot is not installed in Beam Playground#38074
liferoad wants to merge 1 commit intoapache:masterfrom
liferoad:fix/pydot-nameerror-playground

Conversation

@liferoad
Copy link
Copy Markdown
Contributor

@liferoad liferoad commented Apr 4, 2026

What

When pydot is not installed, the import in pipeline_graph.py fails silently (caught by except ImportError: pass), and subsequent calls to pydot.Dot() raise a confusing NameError with no context about what is missing or how to fix it.

How

_construct_graph() now checks if pydot is available before use and raises a clear RuntimeError with install instructions instead.

Testing

Manually verified the fix works by importing the module with and without pydot installed.

Fixes #37829

When pydot is not installed, the import in pipeline_graph.py fails
silently (caught by 'except ImportError: pass'), and subsequent calls
to pydot.Dot() raise a confusing NameError with no context.

Now _construct_graph() checks if pydot is available before use and
raises a clear RuntimeError with install instructions instead.

Fixes apache#37829
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the error handling in the Beam Playground's pipeline graph generation. By explicitly checking for the presence of the pydot dependency, it prevents confusing runtime errors and provides actionable feedback to users when the library is missing.

Highlights

  • Error Handling Improvement: Added a check to verify pydot availability before graph construction.
  • User Feedback: Replaced a cryptic NameError with a clear RuntimeError providing installation instructions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto Amar3tto self-requested a review April 6, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Beam playground pydot is not defined

2 participants