Changes cleanup thread to forceExecute. #38073
Changes cleanup thread to forceExecute. #38073acrites wants to merge 3 commits intoapache:masterfrom
Conversation
… all finalization threads are running.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the initialization of the cleanup thread within the StreamingCommitFinalizer to ensure it starts reliably. By switching to a forced execution strategy, the change avoids deadlock scenarios that can occur when all finalization threads are occupied during worker startup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| // and some tests. | ||
| cleanUpThreadStarted = true; | ||
| finalizationExecutor.execute(this::cleanupThreadBody, 0); | ||
| finalizationExecutor.forceExecute(this::cleanupThreadBody, 0); |
There was a problem hiding this comment.
can we move the forceExecute to after releasing the lock lock.unlock?
There was a problem hiding this comment.
Similar to how it is done in finalizeCommits below.
…to not queue cleanup thread while holding the lock.
| } finally { | ||
| lock.unlock(); | ||
| if (shouldStartCleanupThread) { | ||
| finalizationExecutor.forceExecute(this::cleanupThreadBody, 0); |
There was a problem hiding this comment.
cleanupThreadBody won't ever terminate unless the worker is shutdown right? If so, running cleanupThreadBody in finalizationExecutor will take away a harness thread. Worker will deadlock when run with harnessThreads set to 1. Can we create a separate cleanupThread/threadpool?
We could use a ScheduledThreadPoolExecutor + the schedule methods and remove the custom expiry logic.
There was a problem hiding this comment.
I think this is a great idea!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38073 +/- ##
============================================
+ Coverage 56.89% 58.62% +1.72%
- Complexity 3427 15415 +11988
============================================
Files 1178 2845 +1667
Lines 187542 278719 +91177
Branches 3593 12323 +8730
============================================
+ Hits 106698 163386 +56688
- Misses 77449 108910 +31461
- Partials 3395 6423 +3028
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @tvalentyn added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
waiting on author |
…ice to simplify logic and prevent it from blocking work item processing. Adds an integration test at StreamingDataflowWorker level.
3 participants
Otherwise, we can deadlock if all finalization threads are running. This can happen if e.g. a worker starts up and the pipeline has already been running. It then first gets a bunch of ids to execute and then gets gets a callback to register, which starts up the cleanup thread.
This PR also moves cleanups to a separate ScheduledExecutorService to simplify the cleanup logic as well as prevent it from blocking WorkItem processing.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.