Skip to content

GH-49392: [C++][Compute] Fix fixed-width gather byte offset overflow in list filtering #49602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanmato1984 merged 2 commits into from
Mar 30, 2026
Merged

GH-49392: [C++][Compute] Fix fixed-width gather byte offset overflow in list filtering #49602

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e45a927
GH-49392: [C++][Compute] Fix fixed-width gather byte offset overflow
zanmato1984 Mar 26, 2026
c2ab677
GH-49392: Remove helper-level gather test
zanmato1984 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cpp/src/arrow/compute/kernels/gather_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@

namespace arrow::internal {

template <typename IndexType>
constexpr int64_t FixedWidthByteOffset(IndexType index, int64_t value_width) {
return static_cast<int64_t>(index) * value_width;
}

// CRTP [1] base class for Gather that provides a gathering loop in terms of
// Write*() methods that must be implemented by the derived class.
//
Expand Down Expand Up @@ -185,8 +190,8 @@ class Gather : public GatherBaseCRTP<Gather<kValueWidthInBits, IndexCType, kWith
memcpy(out_ + position * scaled_factor, src_ + idx_[position] * scaled_factor,
scaled_factor);
} else {
memcpy(out_ + position * kValueWidth, src_ + idx_[position] * kValueWidth,
kValueWidth);
memcpy(out_ + FixedWidthByteOffset(position, kValueWidth),
src_ + FixedWidthByteOffset(idx_[position], kValueWidth), kValueWidth);
}
}

Expand All @@ -195,7 +200,7 @@ class Gather : public GatherBaseCRTP<Gather<kValueWidthInBits, IndexCType, kWith
const int64_t scaled_factor = kValueWidth * factor_;
memset(out_ + position * scaled_factor, 0, scaled_factor);
} else {
memset(out_ + position * kValueWidth, 0, kValueWidth);
memset(out_ + FixedWidthByteOffset(position, kValueWidth), 0, kValueWidth);
}
}

Expand All @@ -204,7 +209,8 @@ class Gather : public GatherBaseCRTP<Gather<kValueWidthInBits, IndexCType, kWith
const int64_t scaled_factor = kValueWidth * factor_;
memset(out_ + position * scaled_factor, 0, length * scaled_factor);
} else {
memset(out_ + position * kValueWidth, 0, length * kValueWidth);
memset(out_ + FixedWidthByteOffset(position, kValueWidth), 0,
FixedWidthByteOffset(length, kValueWidth));
}
}

Expand Down
Loading