Skip to content

GH-49456: [C++] Use static key/item/value field names for map type again#49457

Merged
raulcd merged 2 commits intoapache:mainfrom
kou:cpp-map-static-field-names
Mar 5, 2026
Merged

GH-49456: [C++] Use static key/item/value field names for map type again#49457
raulcd merged 2 commits intoapache:mainfrom
kou:cpp-map-static-field-names

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Mar 5, 2026

Rationale for this change

This reverts GH-49415 because the previous behavior (using static "key"/"value"/"entries" field names for map type) is better. Our specification defines the static field names.

What changes are included in this PR?

Always use "key"/"value"/"entries" for map type field names.

Are these changes tested?

Yes.

Are there any user-facing changes?

No. This just revers the unreleased change.

@kou kou requested review from lidavidm, raulcd and wgtmac March 5, 2026 07:09
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 5, 2026

⚠️ GitHub issue #49456 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 5, 2026

@wgtmac @lidavidm @raulcd Sorry. I was wrong. GH-49416 should be reverted. GH-49416 was a backward incompatible change but it's not released yet. So this backward incompatible change will not visible for users.

Copy link
Copy Markdown
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been following the conversation on the ML, this makes sense to me. Thanks @kou
I am wondering whether a comment could be added here so someone reading the code in the future doesn't have the same questions/concerns?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Mar 5, 2026
@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 5, 2026

Good point! I've added a comment.

@raulcd raulcd merged commit f2b4e34 into apache:main Mar 5, 2026
52 of 55 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Mar 5, 2026
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f2b4e34.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the cpp-map-static-field-names branch March 6, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants