GH-49456: [C++] Use static key/item/value field names for map type again#49457
Merged
raulcd merged 2 commits intoapache:mainfrom Mar 5, 2026
Merged
GH-49456: [C++] Use static key/item/value field names for map type again#49457raulcd merged 2 commits intoapache:mainfrom
raulcd merged 2 commits intoapache:mainfrom
Conversation
…ype again This reverts apacheGH-49415.
|
|
wgtmac
approved these changes
Mar 5, 2026
Member
Author
|
Good point! I've added a comment. |
lidavidm
approved these changes
Mar 5, 2026
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f2b4e34. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This reverts GH-49415 because the previous behavior (using static "key"/"value"/"entries" field names for map type) is better. Our specification defines the static field names.
What changes are included in this PR?
Always use "key"/"value"/"entries" for map type field names.
Are these changes tested?
Yes.
Are there any user-facing changes?
No. This just revers the unreleased change.