GH-49159: [C++][Gandiva] Detect overflow in repeat() #49160
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: Gandiva
awaiting committer review
Member
Author
|
@lriggs @akravchukdremio @xxlaykxx You may want to review this. |
raulcd
approved these changes
Feb 9, 2026
github-actions
bot
added
awaiting merge
Member
|
@pitrou what do you think about this? |
xxlaykxx
approved these changes
Feb 9, 2026
pitrou
reviewed
Feb 9, 2026
kou
commented
Feb 10, 2026
github-actions
bot
added
awaiting changes
kou
commented
Feb 10, 2026
github-actions
bot
added
awaiting change review
Member
|
@pitrou I plan to merge this in a couple hours and proceed with the release. Just in case you want to take a look at the latest change. |
pitrou
approved these changes
Feb 10, 2026
raulcd
pushed a commit
that referenced
this pull request
Feb 10, 2026
### Rationale for this change `repeat()` can only generate `< 2147483647` size output. So output larger than `2147483647` must be rejected. ### What changes are included in this PR? Add overflow check in `repeat()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #49159 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
repeat()can only generate< 2147483647size output. So output larger than2147483647must be rejected.What changes are included in this PR?
Add overflow check in
repeat().Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
repeat()doesn't check output size #49159