This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Fix: Now correctly allows to override ElementFinder and ElementArrayFinder methods#5328
Open
Xotabu4 wants to merge 2 commits intoangular:masterfrom
Open
Fix: Now correctly allows to override ElementFinder and ElementArrayFinder methods#5328Xotabu4 wants to merge 2 commits intoangular:masterfrom
Xotabu4 wants to merge 2 commits intoangular:masterfrom
Conversation
CrispusDH
reviewed
Oct 8, 2019
| } | ||
| // TODO(juliemr): might it be easier to combine this with our docs and just | ||
| // wrap each one explicity with its own documentation? | ||
| WEB_ELEMENT_FUNCTIONS.forEach((fnName) => { |
Contributor
There was a problem hiding this comment.
if fnName can be only string you could add this type
CrispusDH
reviewed
Oct 8, 2019
| // TODO(juliemr): might it be easier to combine this with our docs and just | ||
| // wrap each one explicity with its own documentation? | ||
| WEB_ELEMENT_FUNCTIONS.forEach((fnName) => { | ||
| ElementArrayFinder.prototype[fnName] = function (...args: any[]) { |
Contributor
There was a problem hiding this comment.
do you need here () as you did for ElementFinder ((ElementFinder.prototype[fnName]))?
Contributor
|
@cnishina could you take a look at it useful PR? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Now correctly allows to override ElementFinder and ElementArrayFinder methods
Monkey-patching was done in ElementFinder constructor against 'this'. It means this monkey-patching is applied AFTER all methods in inherited objects declared - it will just replace them. Here is list of WebElement methods, that is monkey-patched into ElementFinder:
let WEB_ELEMENT_FUNCTIONS = [
'click', 'sendKeys', 'getTagName', 'getCssValue', 'getAttribute', 'getText', 'getRect',
'isEnabled', 'isSelected', 'submit', 'clear', 'isDisplayed', 'getId', 'takeScreenshot'
];
Before this PR code above would not be working - since monkey-patching is overrides methods declared in child classes:
Xotabu4/protractor-element-extend#20