fix(aria/combobox): fix autocomplete examples and add comments explaining combobox selection behavior #32714
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
added
Accessibility
|
Deployed dev-app for a8d39f8 to: https://ng-dev-previews-comp--pr-angular-components-32714-dev-3240cirt.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
tjshiu
reviewed
Jan 30, 2026
Contributor
tjshiu
left a comment
tjshiu
left a comment
There was a problem hiding this comment.
Chatted about it - might need some more investigation time. Seems to work inconsistently.
adolgachev
force-pushed
the
aria-combobox-nav
branch
from
103fe8e to
2db54b8
Compare
…ning combobox selection behavior
adolgachev
force-pushed
the
aria-combobox-nav
branch
from
e9d01d1 to
a8d39f8
Compare
adolgachev
changed the title
adolgachev
requested review from
ok7sai and
tjshiu
and removed request for
wagnermaciel
adolgachev
removed
the
action: presubmit
adolgachev
added
action: merge
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete examples were actually incorrectly using ngModel to populate the input value, which was colliding with the ngComboboxInput usage of [value} so clearing the query did not work properly.
Updated all the examples to check and clear the value on the ComboboxInput instead.
Also added clarifying comments in the Combox behavior logic which checks for an active item, then drops it, but then checks again when selecting.