test(@angular/build): verify coverage ignore comments are preserved during compilation#32899
Draft
clydin wants to merge 2 commits intoangular:mainfrom
Draft
test(@angular/build): verify coverage ignore comments are preserved during compilation#32899clydin wants to merge 2 commits intoangular:mainfrom
clydin wants to merge 2 commits intoangular:mainfrom
Conversation
clydin
force-pushed
the
vitest/coverage-tests
branch
7 times, most recently
from
6af4619 to
bf91489
Compare
When script optimization is disabled, set esbuild `legalComments` to 'inline' to prevent it from moving ignore comments to the end of the file. This ensures that coverage tools (like Istanbul and V8) can find the comments in place and correctly associate them with the code they are supposed to ignore.
clydin
force-pushed
the
vitest/coverage-tests
branch
5 times, most recently
from
715bca2 to
aa96e44
Compare
…uring compilation The underlying Vitest coverage engine depends on specific developer comments like `/* istanbul ignore next */` or `/* v8 ignore next */` being present in the executing code to accurately isolate unmeasured blocks. This commit adds strict behavioral tests to assert that the Angular CLI's in-memory compilation pipeline (via esbuild) properly preserves these structural comments and forwards them reliably to Vitest's coverage processing engine.
clydin
force-pushed
the
vitest/coverage-tests
branch
from
aa96e44 to
7d98382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying Vitest coverage engine depends on specific developer comments like
/* istanbul ignore next */or/* v8 ignore next */being present in the executing code to accurately isolate unmeasured blocks.This commit adds strict behavioral tests to assert that the Angular CLI's in-memory compilation pipeline (via esbuild) properly preserves these structural comments and forwards them reliably to Vitest's coverage processing engine.