Cancel pending futures on target-score or early-stop termination#419
Open
jink-ucla wants to merge 1 commit intoalgorithmicsuperintelligence:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
ProcessParallelController.run_evolution()stop work faster when termination conditions are already met.Problem
When a run reaches
target_scoreor triggers early stopping, pending futures may continue running unnecessarily until natural completion. Thiswastes compute and delays clean shutdown.
Changes
termination_reasontracking inrun_evolution.target_scoreearly_stoppingshutdownno_pending_futuresmax_iterationstest_target_score_fast_exit_cancels_pending_futuresWhy this is safe
Validation