chore: Warn if user has interactive elements in their custom Picker value#9710
Merged
chore: Warn if user has interactive elements in their custom Picker value#9710
Conversation
|
Build successful! 🎉 |
LFDanLu
commented
Feb 27, 2026
Comment on lines
+495
to
+499
| let INTERACTIVE_ARIA_ROLES = new Set([ | ||
| 'application', 'button', 'checkbox', 'combobox', 'gridcell', 'link', 'menuitem', | ||
| 'menuitemcheckbox', 'menuitemradio', 'option', 'radio', 'searchbox', 'separator', | ||
| 'slider', 'spinbutton', 'switch', 'tab', 'textbox', 'treeitem' | ||
| ]); |
Member
Author
There was a problem hiding this comment.
same set as in Pressable
|
Build successful! 🎉 |
reidbarber
approved these changes
Feb 27, 2026
| } as const; | ||
|
|
||
| // https://w3c.github.io/aria/#widget_roles | ||
| let INTERACTIVE_ARIA_ROLES = new Set([ |
Member
There was a problem hiding this comment.
Seems like something we could make into a re-usable utility eventually.
Member
Author
There was a problem hiding this comment.
yep, will pull it out then
devongovett
approved these changes
Feb 27, 2026
pioug
pushed a commit
to pioug/react-spectrum
that referenced
this pull request
Feb 28, 2026
…aseline-tracker * origin/main: feat(S2): S2 ListView (adobe#8878) refactor: Centralize expandedKeys logic in TreeCollection (adobe#9711) chore: Warn if user has interactive elements in their custom Picker value (adobe#9710) feat: S2 unavailable menu item (adobe#9657) fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu (adobe#9691) fix: prevent docs crash by making template elements always append children into .content (adobe#9703) docs(RAC): Add TreeSection docs (adobe#9699) docs(S2): add Typography search view (adobe#9524) docs(S2): fix clipping in Picker custom value AvatarGroup example (adobe#9702) fix: patch additional methods so React doesnt break with template elements (adobe#9385) tentative fix (adobe#9635) docs(S2): fix icon import clipboard content to add underscore for icons starting with number (adobe#9698) feat(S2): add ActionBar support to TreeView (adobe#9695) fix: combobox interactoutside (adobe#9646) fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone (adobe#9678) chore: update storybook to 9 (adobe#8634) docs: improve custom render value S2 Picker example (adobe#9682) # Conflicts: # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From audit
✅ Pull Request Checklist:
📝 Test Instructions:
Test should cover this, but feel free to test the S2 story and make sure that warnings don't appear or modify the story locally to confirm.
🧢 Your Project:
RSP