Skip to content

docs(S2): fix icon import clipboard content to add underscore for icons starting with number#9698

Merged
reidbarber merged 4 commits intomainfrom
fix-icon-import-underscore
Feb 26, 2026
Merged

docs(S2): fix icon import clipboard content to add underscore for icons starting with number#9698
reidbarber merged 4 commits intomainfrom
fix-icon-import-underscore

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Feb 25, 2026

Import statement for icons like 3DAsset were being copied like:

import 3DAsset from '@react-spectrum/s2/icons/3DAsset';

which is invalid. It should be:

import _3DAsset from '@react-spectrum/s2/icons/3DAsset';

Same for the illustrations.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Try copying 3DAsset's import in the icons search, and the illustrations search.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 25, 2026

@rspbot
Copy link

rspbot commented Feb 25, 2026

@rspbot
Copy link

rspbot commented Feb 25, 2026

@reidbarber reidbarber enabled auto-merge February 26, 2026 22:19
@reidbarber reidbarber added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit b14bd61 Feb 26, 2026
30 checks passed
@reidbarber reidbarber deleted the fix-icon-import-underscore branch February 26, 2026 22:58
pioug pushed a commit to pioug/react-spectrum that referenced this pull request Feb 28, 2026
…aseline-tracker

* origin/main:
  feat(S2): S2 ListView (adobe#8878)
  refactor: Centralize expandedKeys logic in TreeCollection (adobe#9711)
  chore: Warn if user has interactive elements in their custom Picker value (adobe#9710)
  feat: S2 unavailable menu item (adobe#9657)
  fix: Ensure that opening a submenu via enter/space moves focus to first item in submenu (adobe#9691)
  fix: prevent docs crash by making template elements always append children into .content (adobe#9703)
  docs(RAC): Add TreeSection docs (adobe#9699)
  docs(S2): add Typography search view (adobe#9524)
  docs(S2): fix clipping in Picker custom value AvatarGroup example (adobe#9702)
  fix: patch additional methods so React doesnt break with template elements (adobe#9385)
  tentative fix (adobe#9635)
  docs(S2): fix icon import clipboard content to add underscore for icons starting with number (adobe#9698)
  feat(S2): add ActionBar support to TreeView (adobe#9695)
  fix: combobox interactoutside (adobe#9646)
  fix: skip native Date fast path when local timezone is overridden via setLocalTimeZone (adobe#9678)
  chore: update storybook to 9 (adobe#8634)
  docs: improve custom render value S2 Picker example (adobe#9682)

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants