Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| } | ||
|
|
||
| /** | ||
| * Returns the list of CSS property names that are allowed as style overrides via the `styles` prop. |
There was a problem hiding this comment.
This one is subject to breaking changes for any added or removed property.
I was originally thinking it might be better to turn the three
allowedOverrides, widthProperties, heightProperties
into macros so people can construct their own getAllowedOverrides, then if we need to change the list, we can still do that inside getAllowedOverrides
However, I realised that this is already subject to breaking changes through our own components to a degree. We cannot remove any. We can safely add them at the moment though since TS will prevent someone from using one that isn't allowed.
So if we add any properties in the future, maybe we have to wrap getAllowedOverrides in a new macro which appends more fields so we don't change this one.
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:getAllowedOverrides+getAllowedOverrides {
+ undefined: any
+ returnVal: undefined
+}/@react-spectrum/s2:centerPadding+centerPadding {
+ minHeight: string
+ returnVal: undefined
+}/@react-spectrum/s2:setColorScheme+setColorScheme {
+ returnVal: undefined
+}/@react-spectrum/s2:mergeStyles+mergeStyles {
+ styles: Array<StyleString | null | undefined>
+ returnVal: undefined
+}/@react-spectrum/s2:StylesProp+StylesProp {
+ S: undefined
+}/@react-spectrum/s2:StylesPropWithHeight+StylesPropWithHeight {
+ S: undefined
+}/@react-spectrum/s2:StylesPropWithoutWidth+StylesPropWithoutWidth {
+ S: undefined
+}/@react-spectrum/s2:UnsafeClassName+UnsafeClassName {
+ U: undefined
+}/@react-spectrum/s2:UnsafeStyles+UnsafeStyles {
+ UNSAFE_className?: UnsafeClassName
+ UNSAFE_style?: CSSProperties
+}/@react-spectrum/s2:StyleProps+StyleProps {
+ UNSAFE_className?: UnsafeClassName
+ UNSAFE_style?: CSSProperties
+ styles?: StylesProp
+}/@react-spectrum/s2:WidthProperties+WidthProperties {
+ W: undefined
+}/@react-spectrum/s2:HeightProperties+HeightProperties {
+ H: undefined
+} |
Exports:
rawandkeyframesexports to the@react-spectrum/s2/stylesub-package only (since they're macros), and keptmergeStylesin the main@react-spectrum/s2package only (it's runtime-only)WidthPropertiesandHeightPropertiesas types for use withgetAllowedOverridesRenamed:
colorSchemeutility tosetColorSchemeto clarify that it sets the color-scheme propertyDocs:
✅ Pull Request Checklist:
📝 Test Instructions:
Verify the new exports and check the new JSDocs and docs additions (including markdown docs page).
🧢 Your Project: