Fix OpenAI Chat stream: prevent tool_calls[].type becoming "functionf…

[plusor]

…unction..."

When merging streaming deltas, delta was converted with as_json.deep_symbolize_keys, which left tool_calls[].type as the string "function". hash_merge_delta concatenates when the existing value is a String (hash[key] += value), so each chunk appended "function" and produced "functionfunctionfunction...".

• Use delta.deep_to_h so the gem returns symbol-keyed hashes with :type => :function. Merges then hit the replace branch and type stays :function.
• Match when :function in process_function_calls for consistency.

[Copilot]

Pull request overview

Fixes an OpenAI Chat streaming merge issue where tool_calls[].type could become "functionfunctionfunction..." due to string concatenation during delta merges.

Changes:

• Convert streaming deltas via api_message.delta.deep_to_h to preserve non-string enum values (preventing hash_merge_delta string concatenation on :type).
• Normalize tool call type handling by switching process_function_calls to compare api_function_call[:type].to_s against "function".

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Missing space after comma. The code has "What's the weather in Boston?",role: "user" but should have a space after the comma for consistency with Ruby style conventions.

Suggested change

	messages: [{ content: "What's the weather in Boston?",role: "user" }],
	messages: [{ content: "What's the weather in Boston?", role: "user" }],

[TonsOfFun]

I've reviewed the PR and addressed the linting issues. Here's a summary:

Linting Fixes Applied

The rubocop issues were in test/providers/open_ai/chat_provider_test.rb:

• Removed extra empty line at class body beginning
• Added spaces inside array brackets per project style rules
• Added missing space after comma

The linting fixes are available in branch pr-296-lint-fix which can be cherry-picked or merged.

Test Validation

• ✅ The test passes successfully
• ✅ The test correctly asserts that type: :function is a symbol (not string) after streaming delta merging
• ✅ The test verifies that arguments are properly concatenated from streaming deltas

The fix properly addresses the original issue where tool_calls[].type was becoming "functionfunctionfunction..." due to string concatenation during delta merges.