Skip to content

Fix golang download url to go.dev#469

Open
178inaba wants to merge 3 commits intoactions:mainfrom
178inaba:fix-golang-org
Open

Fix golang download url to go.dev#469
178inaba wants to merge 3 commits intoactions:mainfrom
178inaba:fix-golang-org

Conversation

@178inaba
Copy link
Contributor

@178inaba 178inaba commented Apr 5, 2024

Description:

golang.org is redirect to go.dev

$ curl -v 'https://golang.org/dl/?mode=json&include=all'
...
< HTTP/2 301
...
< location: https://go.dev/dl/?mode=json&include=all
...
<a href="https://go.dev/dl/?mode=json&amp;include=all">Moved Permanently</a>.

Related issue:

None.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

Since it's only a change in the URL, it seems that no additions to documentation or testing are necessary.

@178inaba 178inaba requested a review from a team as a code owner April 5, 2024 18:06
@krylov-krylov
Copy link

Description:

golang.org is redirect to go.dev

$ curl -v 'https://golang.org/dl/?mode=json&include=all'
...
< HTTP/2 301
...
< location: https://go.dev/dl/?mode=json&include=all
...
<a href="https://go.dev/dl/?mode=json&amp;include=all">Moved Permanently</a>.

Related issue:

None.

Check list:

  • [ ] Mark if documentation changes are required.
  • [ ] Mark if tests were added or updated to cover the changes.

Since it's only a change in the URL, it seems that no additions to documentation or testing are necessary.

@dmitris
Copy link

dmitris commented Jun 6, 2025

@178inaba - could you resolve the conflicts, please? Hopefully it would help to get this small change finally landed 🙏

@178inaba
Copy link
Contributor Author

178inaba commented Jun 8, 2025

@dmitris
Thanks for your comment! I've resolved the conflicts via rebase.
Please let me know if there's anything else I should update 🙇

@priyagupta108
Copy link
Contributor

Hi @178inaba ,
Thank you for your contribution! Could you please rebase your branch onto the latest main to resolve any conflicts and make sure your changes are up-to-date with the current codebase? This will help us review and merge your PR smoothly.
Thanks!

Copilot AI review requested due to automatic review settings February 5, 2026 11:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Go download URL from the legacy golang.org domain to the current go.dev domain, as golang.org now redirects to go.dev.

Changes:

  • Replaced hardcoded golang.org URL with a constant GOLANG_DOWNLOAD_URL pointing to go.dev
  • Updated documentation reference to reflect the new URL

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
src/installer.ts Introduced GOLANG_DOWNLOAD_URL constant and replaced two instances of hardcoded golang.org URL
README.md Updated documentation link from golang.org to go.dev

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@178inaba
Copy link
Contributor Author

178inaba commented Feb 5, 2026

Hi @priyagupta108 , thanks for the review!

I've rebased my branch onto the latest main. Please take a look when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants