feat(chart-scale-set): Add support for custom dind image and imagePullPolicy#4333
Open
djetelina wants to merge 1 commit intoactions:masterfrom
Open
feat(chart-scale-set): Add support for custom dind image and imagePullPolicy#4333djetelina wants to merge 1 commit intoactions:masterfrom
djetelina wants to merge 1 commit intoactions:masterfrom
Conversation
|
this should get merged, same solution as the "runner" |
|
I’m looking forward to seeing this merged 👀 |
|
We've implemented this fix with a few additional changes, since the Schema spec doesn't accept so add this to line 171 in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3709 , this is not the first PR that attempts to fix it. I saw the comment about redisgning the chart rather than patching it, but since this is the 3rd most requested feature based on the issue tracker, surely simple patch like this, which follows what's possible for the runner itself, is good solution in the meantime.