Skip to content

Fix incorrect timing parameter passed to run_scanners #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 3 commits into
base: develop
Choose a base branch
from
+15 −3
Open

Fix incorrect timing parameter passed to run_scanners #4783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cac709
Fix incorrect timing parameter passed to run_scanners
codewithfourtix Mar 1, 2026
88c3ef7
Add regression test for timing flag not collecting timings
codewithfourtix Mar 2, 2026
11c4237
Fix test decorators on test_scan_without_timing_flag
codewithfourtix Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scancode/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ def echo_func(*_args, **_kwargs):
codebase=codebase,
processes=processes,
timeout=timeout,
timing=timeout,
timing=timing,
quiet=quiet,
verbose=verbose,
kwargs=requested_options,
Expand Down
16 changes: 14 additions & 2 deletions tests/scancode/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,8 +786,20 @@ def test_scan_with_timing_json_return_timings_for_each_scanner():
check_timings(expected, file_results)


@pytest.mark.scanslow
@pytest.mark.skipif(on_windows, reason='Somehow this test fails for now on Python 3')
def test_scan_without_timing_flag_does_not_collect_scan_timings():
test_dir = test_env.extract_test_tar('timing/basic.tgz')
result_file = test_env.get_temp_file('json')
args = ['--email', '--url', '--license', '--copyright', '--info',
'--package', '--json', result_file, test_dir]
run_scan_click(args)
file_results = load_json_result(result_file)['files']
for res in file_results:
if res['type'] == 'file':
assert not res.get('scan_timings'), (
'scan_timings should be empty when --timing is not passed'
)


def test_scan_with_timing_jsonpp_return_timings_for_each_scanner():
test_dir = test_env.extract_test_tar('timing/basic.tgz')
result_file = test_env.get_temp_file('json')
Expand Down
Loading