Remove duplicate '/project.clj' key in _MANIFEST_ENDS dict#4781
Open
codewithfourtix wants to merge 1 commit intoaboutcode-org:developfrom
Open
Remove duplicate '/project.clj' key in _MANIFEST_ENDS dict#4781codewithfourtix wants to merge 1 commit intoaboutcode-org:developfrom
codewithfourtix wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
The '/project.clj': 'clojure' entry appeared twice in the _MANIFEST_ENDS dictionary in classify.py. The second entry silently overwrote the first. Remove the duplicate to clean up the code. Signed-off-by: codewithfourtix <codewithfourtix@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR cleans up src/summarycode/classify.py by removing a duplicated '/project.clj': 'clojure' entry in the _MANIFEST_ENDS dict (duplicate dict keys are silently overwritten in Python, so this is a no-op behaviorally).
Changes:
- Removed the redundant
'/project.clj': 'clojure'entry from_MANIFEST_ENDS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate
/project.cljkey in_MANIFEST_ENDSdictionarySummary
The
'/project.clj': 'clojure'entry appeared twice in the_MANIFEST_ENDSdictionary insrc/summarycode/classify.py. In Python, duplicate keys in a dict literal are silently allowed — the second value overwrites the first. This duplicate was a copy-paste error. Removed the redundant first entry to clean up the code.Changes
'/project.clj': 'clojure'entry from the_MANIFEST_ENDSdictionary insrc/summarycode/classify.pyRoot Cause
This was a copy-paste error. The entry was accidentally duplicated when
'/project.clj': 'clojure'was added again further down in the same dictionary (line 57 and line 66).Testing
Tasks