Skip to content

Remove duplicate '/project.clj' key in _MANIFEST_ENDS dict#4781

Open
codewithfourtix wants to merge 1 commit intoaboutcode-org:developfrom
codewithfourtix:fix-duplicate-manifest-key
Open

Remove duplicate '/project.clj' key in _MANIFEST_ENDS dict#4781
codewithfourtix wants to merge 1 commit intoaboutcode-org:developfrom
codewithfourtix:fix-duplicate-manifest-key

Conversation

@codewithfourtix
Copy link

Remove duplicate /project.clj key in _MANIFEST_ENDS dictionary

Summary

The '/project.clj': 'clojure' entry appeared twice in the _MANIFEST_ENDS dictionary in src/summarycode/classify.py. In Python, duplicate keys in a dict literal are silently allowed — the second value overwrites the first. This duplicate was a copy-paste error. Removed the redundant first entry to clean up the code.

Changes

  • Removed the duplicate '/project.clj': 'clojure' entry from the _MANIFEST_ENDS dictionary in src/summarycode/classify.py

Root Cause

This was a copy-paste error. The entry was accidentally duplicated when '/project.clj': 'clojure' was added again further down in the same dictionary (line 57 and line 66).

Testing

  • No functional change — behavior is identical since the duplicate key was already being silently overwritten by Python
  • Existing tests should pass without modification

Tasks

The '/project.clj': 'clojure' entry appeared twice in the
_MANIFEST_ENDS dictionary in classify.py. The second entry
silently overwrote the first. Remove the duplicate to clean
up the code.

Signed-off-by: codewithfourtix <codewithfourtix@gmail.com>
Copilot AI review requested due to automatic review settings March 1, 2026 14:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up src/summarycode/classify.py by removing a duplicated '/project.clj': 'clojure' entry in the _MANIFEST_ENDS dict (duplicate dict keys are silently overwritten in Python, so this is a no-op behaviorally).

Changes:

  • Removed the redundant '/project.clj': 'clojure' entry from _MANIFEST_ENDS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants