Skip to content

Increase query resolver's function arguments: 9 to 19#172

Open
ima9dan wants to merge 4 commits intoaPureBase:mainfrom
ima9dan:add-function-wrapper
Open

Increase query resolver's function arguments: 9 to 19#172
ima9dan wants to merge 4 commits intoaPureBase:mainfrom
ima9dan:add-function-wrapper

Conversation

@ima9dan
Copy link

@ima9dan ima9dan commented Dec 7, 2021

The maximum function argument for the query resolver was 9.
However, there were cases where that was not enough, so I added it.

example

query ("test") {
    description = "test"
    resolver {
        arg1:String?, arg2:String?, arg3:String?, arg4:String?, arg5:String?, arg6:String?, arg7:String?,
            arg8:String?, arg9:String?, arg10:String?, arg11:String?,arg12:String?,arg13:String?,arg14:String?,
            arg15:String?, arg16:String?, arg17:String?, arg18:String?, arg19:String? ->

        true
    }
}

@xplayerCZ
Copy link

Isn't grouping arguments in object a better way to approach this issue? Like Filter, Sort etc. This number of arguments seems brutal for production use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants