Skip to content

Comments

feat: add getMetadata method for RequestContext#677

Merged
kabir merged 2 commits intoa2aproject:mainfrom
flex-myeonghyeon:feat-add-metadata-for-request-context
Feb 24, 2026
Merged

feat: add getMetadata method for RequestContext#677
kabir merged 2 commits intoa2aproject:mainfrom
flex-myeonghyeon:feat-add-metadata-for-request-context

Conversation

@flex-myeonghyeon
Copy link
Contributor

@flex-myeonghyeon flex-myeonghyeon commented Feb 21, 2026

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @flex-myeonghyeon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to the RequestContext by exposing request metadata. This enhancement allows other components to easily access additional context associated with a request, improving the flexibility and information richness of the request handling process. The change is fully covered by new unit tests to ensure correctness.

Highlights

  • New Feature: Metadata Access: A new getMetadata() method has been added to the RequestContext class, allowing retrieval of request-specific metadata as an unmodifiable map.
  • Unit Test Coverage: Comprehensive unit tests have been introduced for the getMetadata() method, covering scenarios where metadata is null and when it is populated.
Changelog
  • server-common/src/main/java/io/a2a/server/agentexecution/RequestContext.java
    • Imported java.util.Map.
    • Added a public getMetadata() method to retrieve request metadata, returning an unmodifiable map or null.
  • server-common/src/test/java/io/a2a/server/agentexecution/RequestContextTest.java
    • Imported java.util.HashMap.
    • Verified getMetadata() returns null when no parameters are provided in testInitWithoutParams.
    • Added a new test case testInitWithParamsMetadata to confirm correct metadata retrieval when parameters are set.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a getMetadata method to RequestContext to expose request metadata. The implementation is correct and includes corresponding tests. I've suggested a small improvement to the tests to verify the immutability of the returned metadata map, which is an important contract to enforce.

@kabir
Copy link
Collaborator

kabir commented Feb 24, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new getMetadata method to the RequestContext class, allowing access to request-specific metadata. The change also includes corresponding test cases to ensure its functionality and immutability. The implementation correctly handles null cases and returns an unmodifiable map, which is good for preventing external modifications. The changes are well-contained and address the stated feature request effectively.

Copy link
Collaborator

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmesnil @ehsavoie I approved this, please one of you see if you agree

@kabir kabir merged commit e4e844f into a2aproject:main Feb 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants