Improve site icon but don't change the UI by aaronjorbin · Pull Request #6165 · WordPress/wordpress-develop

aaronjorbin · 2024-02-22T20:13:30Z

This is a copy of #6109 but with the existing UI rather than a new one.

https://core.trac.wordpress.org/ticket/54370

…$. Wrap feature in a function

…et/wordpress-develop into 54370-site-icon-post-review

…4370-site-icon-post-review

…review in the cropper

…4370-site-icon-post-review

npx prettier@npm:wp-prettier@latest --write src/js/_enqueues/admin/site-icon.js npx prettier@npm:wp-prettier@latest --write src/wp-admin/css/site-icon.css

github-actions · 2024-02-22T20:49:30Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

src/js/_enqueues/admin/site-icon.js

src/wp-admin/options-general.php

src/wp-includes/script-loader.php

src/wp-admin/options-general.php

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>

…4370-site-icon-post-review-old-ui

…jorbin/wordpress-develop into 54370-site-icon-post-review-old-ui

github-actions · 2024-02-23T17:08:51Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kebbet, jorbin, swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

swissspidy · 2024-02-23T20:52:23Z

src/js/_enqueues/admin/site-icon.js

+			switchToUpdate( attachment );
+			frame.close();
+
+			// Start over with a frame that is so fresh and so clean clean.


This comment was flagged as odd, and I agree. Is this an Outkast reference or something?

kebbet added 30 commits February 14, 2024 08:18

Fix typo

cb96657

Adds data-choose attribute for media modal

cfffe29

Adds docblocks, removes wrapping function.

ff3ef3a

Adds since tag, follow coding standards I guess.

44ca10d

Store selected elements in vars.

ed9df2c

Updates docblock, move frame into initializing function

54a0565

Reduce calls to .attr(). Remove classes var

e584698

Adds space before the opening brackets

233f89b

Reuse existing attribute, rename selector (in PHP)

8ffc136

Address review comments from @afercia

5a97e40

Merge branch 'WordPress:trunk' into 54370-site-icon-post-review

a3020b6

JS-fixes

c930802

Focus loss and fixed button ID for triggering modal.

c695e3c

Removes unnecessary setting of focus

564cdbd

Coding standard fixes.

cb268c4

Merge branch 'WordPress:trunk' into 54370-site-icon-post-review

1d696f7

Updates docblocks, combine var-statements, start jQuery objects with …

edb1546

…$. Wrap feature in a function

Merge branch 'WordPress:trunk' into 54370-site-icon-post-review

8269ea3

Accessibility: adds better alternative text to the images

10fe004

CS-issue with to many tabs.

71f353f

CS-issue

18e9c1e

Missing semicolons.

142fec6

Handle alt-attribute on remove

63f3885

Remove debug log.

d7b30c0

Remove IIFE-sections, adjusts indents. Move var to function scope

f540014

Merge branch 'WordPress:trunk' into 54370-site-icon-post-review

84a7d4b

Temp reset

b5c43ed

Merge branch '54370-site-icon-post-review' of https://github.com/kebb…

e79e952

…et/wordpress-develop into 54370-site-icon-post-review

Remove IIFE-sections, adjusts indents. Move var to function scope

07c9089

Merge branch 'WordPress:trunk' into 54370-site-icon-post-review

ebfd54b

aaronjorbin and others added 12 commits February 21, 2024 11:55

Fix indentation

7b67b64

Merge branch 'trunk' of github.com:WordPress/wordpress-develop into 5…

f023335

…4370-site-icon-post-review

Update Title in preview as it chagnes

254a288

Update background for preview with the new image

57f3d4a

Remove float which was used in old UI as it is interfering with the p…

6564f9b

…review in the cropper

Merge branch 'trunk' of github.com:WordPress/wordpress-develop into 5…

69416b4

…4370-site-icon-post-review

Restore alt text for browser and remove svg from screen reader

b76e500

Use <code> tag for size info.

16a3a8c

Tidy CSS and add border to preview field.

91fb8a8

use prettier to format CSS and JS

9b68ef5

npx prettier@npm:wp-prettier@latest --write src/js/_enqueues/admin/site-icon.js npx prettier@npm:wp-prettier@latest --write src/wp-admin/css/site-icon.css

Restore current UI

984a20c

fix jshint issues caused by prettier

3ff7d7a

swissspidy mentioned this pull request Feb 22, 2024

54370 site icon post review #6109

Closed

swissspidy reviewed Feb 22, 2024

View reviewed changes

aaronjorbin commented Feb 22, 2024

View reviewed changes

src/wp-admin/options-general.php Outdated Show resolved Hide resolved

aaronjorbin and others added 7 commits February 22, 2024 17:49

Remove no longer used UI code

1116243

Lowercase translators

e8f7676

Reuse admin bar update code for site icon preview

abe815b

use bloginfo which does echo get_bloginfo

f9ea859

Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>

Merge branch 'trunk' of github.com:WordPress/wordpress-develop into 5…

7941464

…4370-site-icon-post-review-old-ui

Reformat JS based on new jshint

a672eba

Merge branch '54370-site-icon-post-review-old-ui' of github.com:aaron…

ad65152

…jorbin/wordpress-develop into 54370-site-icon-post-review-old-ui

aaronjorbin marked this pull request as ready for review February 23, 2024 17:08

aaronjorbin requested a review from swissspidy February 23, 2024 17:08

swissspidy reviewed Feb 23, 2024

View reviewed changes

swissspidy approved these changes Feb 23, 2024

View reviewed changes

WordPress deleted a comment from lenaseo22 Apr 4, 2024

swissspidy closed this Apr 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve site icon but don't change the UI#6165

Improve site icon but don't change the UI#6165
aaronjorbin wants to merge 75 commits intoWordPress:trunkfrom
aaronjorbin:54370-site-icon-post-review-old-ui

aaronjorbin commented Feb 22, 2024

Uh oh!

github-actions bot commented Feb 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2024 •

edited

Loading

Uh oh!

swissspidy Feb 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

aaronjorbin commented Feb 22, 2024

Uh oh!

github-actions bot commented Feb 22, 2024

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swissspidy Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 23, 2024 •

edited

Loading