Connectors: Change URL to options-connectors.php#11157
Closed
jorgefilipecosta wants to merge 2 commits intoWordPress:trunkfrom
Closed
Connectors: Change URL to options-connectors.php#11157jorgefilipecosta wants to merge 2 commits intoWordPress:trunkfrom
jorgefilipecosta wants to merge 2 commits intoWordPress:trunkfrom
Conversation
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention (options-general.php, options-writing.php, etc.). - Add src/wp-admin/options-connectors.php direct admin file - Add submenu entry in menu.php at position 1 - Update script_module_data filter to options-connectors-wp-admin Props jeremyfelt, flavor13. See #64730.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
commented
Mar 4, 2026
package.json
Outdated
| }, | ||
| "gutenberg": { | ||
| "ref": "022d8dd3d461f91b15c1f0410649d3ebb027207f" | ||
| "ref": "95ecd95bc36c3e794be28250c10f4247761905c8" |
Member
Author
There was a problem hiding this comment.
Temporary ref change needs to be updated when WordPress/gutenberg#76142 is merged and backported to the release branch.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
gziolo
approved these changes
Mar 4, 2026
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Tests well, and the proposed code changes look good.
pento
pushed a commit
that referenced
this pull request
Mar 4, 2026
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (`options-general.php`, `options-writing.php`, etc.). * Adds `src/wp-admin/options-connectors.php` as a direct admin screen file. * Adds a static submenu entry in `menu.php` at position 12 (after General). * Removes `_wp_connectors_add_settings_menu_item()` and its `admin_menu` hook from `connectors.php`. * Updates the `script_module_data` filter from `connectors-wp-admin` to `options-connectors-wp-admin`. Synced from WordPress/gutenberg#76142. Developed in #11157. Follow-up to [61749], [61824]. See #64730. Props jorgefilipecosta, gziolo. Fixes #64790. git-svn-id: https://develop.svn.wordpress.org/trunk@61825 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 4, 2026
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (`options-general.php`, `options-writing.php`, etc.). * Adds `src/wp-admin/options-connectors.php` as a direct admin screen file. * Adds a static submenu entry in `menu.php` at position 12 (after General). * Removes `_wp_connectors_add_settings_menu_item()` and its `admin_menu` hook from `connectors.php`. * Updates the `script_module_data` filter from `connectors-wp-admin` to `options-connectors-wp-admin`. Synced from WordPress/gutenberg#76142. Developed in WordPress/wordpress-develop#11157. Follow-up to [61749], [61824]. See #64730. Props jorgefilipecosta, gziolo. Fixes #64790. Built from https://develop.svn.wordpress.org/trunk@61825 git-svn-id: http://core.svn.wordpress.org/trunk@61112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64730
Follow-up for #11056.
Synced from WordPress/gutenberg#76142.
Ticket: https://core.trac.wordpress.org/ticket/64790
Summary
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (
options-general.php,options-writing.php, etc.).Before:
/wp-admin/admin.php?page=connectors-wp-adminAfter:
/wp-admin/options-connectors.phpChanges
src/wp-admin/options-connectors.phpdirect admin filemenu.phpat position 1 (after General)script_module_datafilter tooptions-connectors-wp-adminTest plan
options-connectors.php