Skip to content

TRAC: 54484 - REST API: Return empty object instead of empty array for meta field #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishalkakadiya wants to merge 3 commits into
base: trunk
Choose a base branch
from
+24 −4
Open

TRAC: 54484 - REST API: Return empty object instead of empty array for meta field #10889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ba0d5
REST API: Return empty object instead of empty array for meta field
Feb 9, 2026
9f4b969
Update test cases
Feb 9, 2026
7cb3147
Update test cases
Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,19 @@ public function filter_response_by_context( $data, $context ) {
unset( $data['title']['rendered'] );
unset( $data['content']['rendered'] );

// Add the core wp_pattern_sync_status meta as top level property to the response.
$data['wp_pattern_sync_status'] = $data['meta']['wp_pattern_sync_status'] ?? '';
unset( $data['meta']['wp_pattern_sync_status'] );
/*
* Add the core wp_pattern_sync_status meta as top level property to the response.
* Handle both array and object (stdClass) meta values.
*/
if ( is_array( $data['meta'] ) && isset( $data['meta']['wp_pattern_sync_status'] ) ) {
$data['wp_pattern_sync_status'] = $data['meta']['wp_pattern_sync_status'];
unset( $data['meta']['wp_pattern_sync_status'] );
} elseif ( is_object( $data['meta'] ) && property_exists( $data['meta'], 'wp_pattern_sync_status' ) ) {
$data['wp_pattern_sync_status'] = $data['meta']->wp_pattern_sync_status;
unset( $data['meta']->wp_pattern_sync_status );
} else {
$data['wp_pattern_sync_status'] = '';
}
return $data;
}

Expand Down
12 changes: 11 additions & 1 deletion src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ public function register_field() {
*
* @param int $object_id Object ID to fetch meta for.
* @param WP_REST_Request $request Full details about the request.
* @return array Array containing the meta values keyed by name.
* @return array|stdClass Array containing the meta values keyed by name,
* or stdClass if empty to ensure JSON object encoding.
*/
public function get_value( $object_id, $request ) {
$fields = $this->get_registered_fields();
Expand Down Expand Up @@ -105,6 +106,11 @@ public function get_value( $object_id, $request ) {
$response[ $name ] = $value;
}

// Use stdClass so that JSON result is {} and not [].
if ( empty( $response ) ) {
return new stdClass();
}

return $response;
}

Expand Down Expand Up @@ -582,6 +588,10 @@ public static function prepare_value( $value, $request, $args ) {
* @return array|false The meta array, if valid, false otherwise.
*/
public function check_meta_is_array( $value, $request, $param ) {
if ( is_object( $value ) ) {
$value = (array) $value;
}

if ( ! is_array( $value ) ) {
return false;
}
Expand Down
Loading