-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Admin Reskin: Cards #10862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabiankaegy
wants to merge
7
commits into
WordPress:trunk
Choose a base branch
from
fabiankaegy:admin-reskin/cards
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−44
Open
Admin Reskin: Cards #10862
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e0468b5
Admin UI: Reskin cards to align with WordPress Design System
fabiankaegy cb86f45
Merge branch 'trunk' into admin-reskin/card
fabiankaegy 9e56da2
fix allignment of handle-actions inside postbox-header
fabiankaegy 6bfe0c0
fix use outline instead of border for dragging dashboard widgets
fabiankaegy b7b65c6
fix use alpha param of rgb instead of rgba
fabiankaegy 59e32be
Apply suggestion from @mukeshpanchal27
fabiankaegy 334bc13
fix invisible column
fabiankaegy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always look a little askance on
overflow: hidden, as it can cause accessibility problems. I don't think it should here, since the class is removed when content is rendered, but can you tell me why it's being added?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
.theme-browser .themeelement is the main theme card. It hasborder-radius: 8px(line 69), which gives the card rounded corners. The.theme-screenshotchild sits flush against the top of the card, and itsimgis absolutely positioned to fill the entire screenshot area.Without
overflow: hiddenon the parent card, the screenshot image would visually "poke out" beyond the rounded corners at the top of the card, rendering with sharp square edges that ignore the parent's border-radius.The card has no scrollable content, and no interactive or focusable elements that could end up clipped out of reach. The theme name area and action buttons all sit within the card's visible bounds.