fix #64581 - Display serialized option values instead of placeholder text

[Presskopp]

Fixes https://core.trac.wordpress.org/ticket/64581

This replaces the hard-coded "SERIALIZED DATA" placeholder in
wp-admin/options.php with a read-only display of the actual
unserialized option value.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props presskopp.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[huzaifaalmesbah]

Could we place this JavaScript in an external file and load it via wp_enqueue_script() for better maintainability?

[Presskopp]

I think we should first wait for a dev feedback on the feasibility of this overall concept. Then we can talk about the specific details.

[anatolinicolae]

What about a native approach instead? Like relying on the <details> tag that basically does the same thing as this JS. I'll give it a try locally later anyway 👍

[anatolinicolae]

Patch looks good, but I'm unsure if we want to unserialize the fields. I would stick to raw values thrown into a textarea but maybe_unserialize makes sense if we disable saving.

<details> version is decent enough for debugging purpose, but we can stick to the cooler "Show serialized value" button for a more native look and feel.

	...

	$value               = $option->option_value;
	$options_to_update[] = $option->option_name;
	$is_serialized       = false;
	$class               = 'all-options';

	if ( is_serialized( $option->option_value ) ) {
		$disabled      = true;
		$is_serialized = true;
		$class        .= ' disabled';
	}

	$name = esc_attr($option->option_name);
?>
	<tr>
		<th scope="row"><label for="<?php echo $name; ?>"><?php echo esc_html($option->option_name); ?></label></th>
		<td>
			<?php if ($is_serialized) : ?>
				<details name="<?php echo $name; ?>" class="<?php echo $class; ?>">
					<summary>SERIALIZED DATA</summary>
					<textarea class="<?php echo $class; ?>" name="<?php echo $name; ?>" id="<?php echo $name; ?>" cols="30" rows="5" disabled="disabled"><?php echo esc_textarea( $value ); ?></textarea>
				</details>
			<?php elseif ( str_contains( $value, "\n" ) ) : ?>
				<textarea class="<?php echo $class; ?>" name="<?php echo $name; ?>" id="<?php echo $name; ?>" cols="30" rows="5"><?php echo esc_textarea( $value ); ?></textarea>
			<?php else : ?>
				<input class="regular-text <?php echo $class; ?>" type="text" name="<?php echo $name; ?>" id="<?php echo $name; ?>" value="<?php echo esc_attr( $value ); ?>"<?php disabled( $disabled, true ); ?> />
			<?php endif; ?>
		</td>
	</tr>
<?php endforeach; ?>

Similarly for network's site-settings.php:

$value         = $option->option_value;
$is_serialized = false;
$disabled      = false;
$class         = 'all-options';

if ( is_serialized( $option->option_value ) ) {
	$is_serialized = true;
	$disabled      = true;
	$class        .= ' disabled';
}

if ( $is_serialized ) {
	?>
	<tr class="form-field">
		<th scope="row"><label for="<?php echo esc_attr( $option->option_name ); ?>" class="code"><?php echo esc_html( $option->option_name ); ?></label></th>
		<td>
			<details name="<?php echo esc_attr( $option->option_name ); ?>" class="<?php echo $class; ?>">
				<summary>SERIALIZED DATA</summary>
				<textarea class="<?php echo $class; ?>" name="option[<?php echo esc_attr( $option->option_name ); ?>]" id="<?php echo esc_attr( $option->option_name ); ?>" cols="30" rows="5" disabled="disabled"><?php echo esc_textarea( $value ); ?></textarea>
			</details>
		</td>
	</tr>
	<?php
} elseif ( str_contains( $value, "\n" ) ) {
	?>
	<tr class="form-field">
		<th scope="row"><label for="<?php echo esc_attr( $option->option_name ); ?>" class="code"><?php echo esc_html( $option->option_name ); ?></label></th>
		<td><textarea class="<?php echo $class; ?>" rows="5" cols="40" name="option[<?php echo esc_attr( $option->option_name ); ?>]" id="<?php echo esc_attr( $option->option_name ); ?>"<?php disabled( $disabled ); ?>><?php echo esc_textarea( $value ); ?></textarea></td>
	</tr>
	<?php
} else {
	?>
	<tr class="form-field">
		<th scope="row"><label for="<?php echo esc_attr( $option->option_name ); ?>" class="code"><?php echo esc_html( $option->option_name ); ?></label></th>
		<?php if ( $is_main_site && in_array( $option->option_name, array( 'siteurl', 'home' ), true ) ) { ?>
		<td><code><?php echo esc_html( $value ); ?></code></td>
		<?php } else { ?>
		<td><input class="<?php echo $class; ?>" name="option[<?php echo esc_attr( $option->option_name ); ?>]" type="text" id="<?php echo esc_attr( $option->option_name ); ?>" value="<?php echo esc_attr( $value ); ?>" size="40" <?php disabled( $disabled ); ?> /></td>
		<?php } ?>
	</tr>
	<?php
}

[anatolinicolae]

Suggested change

	$value = $option->option_value;
	$options_to_update[] = $option->option_name;
	$is_serialized = false;
	if ( is_serialized( $option->option_value ) ) {
	$disabled = true;
	$is_serialized = true;
	}
	$class = 'all-options';
	if ( $disabled ) {
	$class .= ' disabled';
	}
	$name = esc_attr( $option->option_name );
	?>
	<tr>
	<th scope="row"><label
	for="<?php echo $name; ?>"><?php echo esc_html( $option->option_name ); ?></label></th>
	<td>
	<?php if ( $is_serialized ) : ?>
	<details name="<?php echo $name; ?>" class="<?php echo $class; ?>">
	<summary>SERIALIZED DATA</summary>
	<textarea class="<?php echo $class; ?>" name="<?php echo $name; ?>"
	id="<?php echo $name; ?>" cols="30" rows="5"
	disabled="disabled"><?php echo esc_textarea( $value ); ?></textarea>
	</details>
	<?php elseif ( str_contains( $value, "\n" ) ) : ?>
	<textarea class="<?php echo $class; ?>" name="<?php echo $name; ?>"
	id="<?php echo $name; ?>" cols="30"
	rows="5"><?php echo esc_textarea( $value ); ?></textarea>
	<?php else : ?>
	<input class="regular-text <?php echo $class; ?>" type="text" name="<?php echo $name; ?>"
	id="<?php echo $name; ?>"
	value="<?php echo esc_attr( $value ); ?>"<?php disabled( $disabled, true ); ?> />
	<?php endif; ?>
	</td>
	</tr>
	<?php endforeach; ?>