-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Navigation overlay: backport patterns and template part definition #10844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mikachan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well for me 🙌
- Verify navigation pattern category appears in the block pattern inserter ✅
- Verify all five navigation overlay patterns are available and render correctly ✅
- Verify navigation overlay template parts can be created and used ✅
- Test pattern insertion in the site editor ✅
- Pattern naming and descriptions make sense ✅
If there are any issues, we can address them during the beta period.
|
Rebase and then we should be good to land 🙏 |
This PR backports core PHP changes from Gutenberg that remove the overlay experiment and migrate navigation overlay patterns to use the core namespace.
This backport includes the following core changes:
Navigation Pattern Category: Adds the
navigationblock pattern category registration inblock-patterns.php.Navigation Overlay Patterns: Adds five new navigation overlay block patterns.
Template Part Area Constant: Adds the
WP_TEMPLATE_PART_AREA_NAVIGATION_OVERLAYconstant and corresponding area definition inblock-template-utils.phpto support navigation overlay template parts.This backport is based on changes from WordPress/gutenberg#74968
Testing
Trac ticket: https://core.trac.wordpress.org/ticket/64589
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.