Add kw_only to remaining vws.reports dataclasses#2934
Merged
adamtheturtle merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
TargetData, QueryResult, and TargetStatusAndRecord now match other report types and require keyword arguments at construction time. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
kw_only=TruetoTargetData,QueryResult, andTargetStatusAndRecordso all dataclasses in this module consistently require keyword arguments. Existing construction sites already use keywords.Made with Cursor
Note
Low Risk
Low risk: this only makes
TargetData,QueryResult, andTargetStatusAndRecordkeyword-only, and existing construction in this module already uses keyword arguments. Risk is limited to any external callers that may still instantiate these dataclasses positionally.Overview
Makes
TargetData,QueryResult, andTargetStatusAndRecorddataclasses insrc/vws/reports.pykeyword-only by addingkw_only=True, aligning them with the rest of the module’s dataclasses.This is an API-surface tightening change that prevents positional instantiation of these types while leaving parsing/construction via
from_response_dictunchanged.Written by Cursor Bugbot for commit bb57189. This will update automatically on new commits. Configure here.