Skip to content

Add kw_only to remaining vws.reports dataclasses#2934

Merged
adamtheturtle merged 1 commit intomainfrom
dataclass-kw-only-reports
Mar 29, 2026
Merged

Add kw_only to remaining vws.reports dataclasses#2934
adamtheturtle merged 1 commit intomainfrom
dataclass-kw-only-reports

Conversation

@adamtheturtle
Copy link
Copy Markdown
Member

@adamtheturtle adamtheturtle commented Mar 29, 2026

Adds kw_only=True to TargetData, QueryResult, and TargetStatusAndRecord so all dataclasses in this module consistently require keyword arguments. Existing construction sites already use keywords.

Made with Cursor


Note

Low Risk
Low risk: this only makes TargetData, QueryResult, and TargetStatusAndRecord keyword-only, and existing construction in this module already uses keyword arguments. Risk is limited to any external callers that may still instantiate these dataclasses positionally.

Overview
Makes TargetData, QueryResult, and TargetStatusAndRecord dataclasses in src/vws/reports.py keyword-only by adding kw_only=True, aligning them with the rest of the module’s dataclasses.

This is an API-surface tightening change that prevents positional instantiation of these types while leaving parsing/construction via from_response_dict unchanged.

Written by Cursor Bugbot for commit bb57189. This will update automatically on new commits. Configure here.

TargetData, QueryResult, and TargetStatusAndRecord now match other
report types and require keyword arguments at construction time.

Made-with: Cursor
@adamtheturtle adamtheturtle merged commit 420fe07 into main Mar 29, 2026
16 checks passed
@adamtheturtle adamtheturtle deleted the dataclass-kw-only-reports branch March 29, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant