Skip to content

Add SecurityTypes column to exported CSV#601

Closed
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07:feature/export-security-types-column
Closed

Add SecurityTypes column to exported CSV#601
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07:feature/export-security-types-column

Conversation

@gioalex07
Copy link
Copy Markdown

Include wiFiSecurityTypesDisplay in the export output as a new SecurityTypes column. This exposes the structured security type information (e.g. [SAE OWE]) already available in the model but missing from the exported data.

Summary

  • Add SecurityTypes column to the exported CSV output.
  • The structured security type information (e.g. [SAE OWE]) was already available in the model via wiFiSecurityTypesDisplay but was not included in the export.

What does this implement/fix?

  • Export.kt: added SecurityTypes header column and wiFiSecurityTypesDisplay(context) field to each exported row
  • ExportTest.kt: updated expected header and all data rows to include the new column

Does this close any issues?

  • N/A (data completeness improvement)

How was this tested?

  • Platform: WSL2 / AlmaLinux 9
  • Build variant: debug
  • Toolchain: JDK 21 (Zulu), Gradle 9.3.1, Android SDK 36
./gradlew ktlintCheck                                              → BUILD SUCCESSFUL
./gradlew testDebugUnitTest                                        → BUILD SUCCESSFUL (3432 tests)
./gradlew testDebugUnitTest --tests "com.vrem.wifianalyzer.export.ExportTest" → BUILD SUCCESSFUL

Checklist (required before marking ready)

  • I added or updated unit tests (see app/src/test/)
  • I followed the project's coding style (ktlint) and formatting
  • I ran lint and addressed or documented any warnings
  • CI checks pass (unit tests, coverage, lint)
  • No sensitive data, keys, or secrets are included

Additional context

The export already included raw capabilities (e.g. [WPA2-PSK-CCMP][ESS]) as the Security column.
The new SecurityTypes column adds the resolved structured representation available from Android 13+
(e.g. [SAE OWE]), making the export more useful for analysis on modern devices.
On devices running Android 12 or earlier the column will contain [] as securityTypes is not populated.

gioalex07 and others added 2 commits April 2, 2026 18:26
Include wiFiSecurityTypesDisplay in the export output as a new
SecurityTypes column. This exposes the structured security type
information (e.g. [SAE OWE]) already available in the model
but missing from the exported data.

Updated ExportTest to reflect the new column in header and rows.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (bd25b4d) to head (55dd36c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #601   +/-   ##
=========================================
  Coverage     97.83%   97.83%           
  Complexity      975      975           
=========================================
  Files           121      121           
  Lines          2581     2582    +1     
  Branches        211      211           
=========================================
+ Hits           2525     2526    +1     
  Misses           19       19           
  Partials         37       37           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VREMSoftwareDevelopment
Copy link
Copy Markdown
Owner

  • Raw capabilities already include the complete security information.
  • The proposed column duplicates existing information and does not provide additional value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants