Add SecurityTypes column to exported CSV#601
Closed
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
Closed
Add SecurityTypes column to exported CSV#601gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07 wants to merge 2 commits intoVREMSoftwareDevelopment:mainfrom
Conversation
Include wiFiSecurityTypesDisplay in the export output as a new SecurityTypes column. This exposes the structured security type information (e.g. [SAE OWE]) already available in the model but missing from the exported data. Updated ExportTest to reflect the new column in header and rows.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=========================================
Coverage 97.83% 97.83%
Complexity 975 975
=========================================
Files 121 121
Lines 2581 2582 +1
Branches 211 211
=========================================
+ Hits 2525 2526 +1
Misses 19 19
Partials 37 37 🚀 New features to boost your workflow:
|
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include wiFiSecurityTypesDisplay in the export output as a new SecurityTypes column. This exposes the structured security type information (e.g. [SAE OWE]) already available in the model but missing from the exported data.
Summary
SecurityTypescolumn to the exported CSV output.[SAE OWE]) was already available in the model viawiFiSecurityTypesDisplaybut was not included in the export.What does this implement/fix?
Export.kt: addedSecurityTypesheader column andwiFiSecurityTypesDisplay(context)field to each exported rowExportTest.kt: updated expected header and all data rows to include the new columnDoes this close any issues?
How was this tested?
./gradlew ktlintCheck → BUILD SUCCESSFUL ./gradlew testDebugUnitTest → BUILD SUCCESSFUL (3432 tests) ./gradlew testDebugUnitTest --tests "com.vrem.wifianalyzer.export.ExportTest" → BUILD SUCCESSFULChecklist (required before marking ready)
app/src/test/)Additional context
The export already included raw
capabilities(e.g.[WPA2-PSK-CCMP][ESS]) as theSecuritycolumn.The new
SecurityTypescolumn adds the resolved structured representation available from Android 13+(e.g.
[SAE OWE]), making the export more useful for analysis on modern devices.On devices running Android 12 or earlier the column will contain
[]assecurityTypesis not populated.