Skip to content

Rename noChildren to hasChildren for clarity#599

Open
gioalex07 wants to merge 1 commit intoVREMSoftwareDevelopment:mainfrom
gioalex07:fix/rename-nochildren-to-haschildren
Open

Rename noChildren to hasChildren for clarity#599
gioalex07 wants to merge 1 commit intoVREMSoftwareDevelopment:mainfrom
gioalex07:fix/rename-nochildren-to-haschildren

Conversation

@gioalex07
Copy link
Copy Markdown

The property noChildren returned true when children were present, which was semantically misleading. Renamed to hasChildren to match the actual behavior and avoid confusion for future contributors.

Summary

  • Rename WiFiDetail.noChildren to hasChildren for semantic clarity.
  • The property name was misleading: noChildren returned true when children were present.

What does this implement/fix?

  • Renamed property in WiFiDetail.kt
  • Updated consumer in AccessPointsAdapterGroup.kt (2 call sites)
  • Updated test names and assertions in WiFiDetailTest.kt and AccessPointsAdapterGroupTest.kt

Does this close any issues?

  • N/A (naming/clarity improvement)

How was this tested?

  • Platform: WSL2 / AlmaLinux 9
  • Build variant: debug
  • Commands run:
./gradlew ktlintCheck     → BUILD SUCCESSFUL
./gradlew testDebugUnitTest → BUILD SUCCESSFUL

The property noChildren returned true when children were present,
which was semantically misleading. Renamed to hasChildren to match
the actual behavior and avoid confusion for future contributors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant