feat: extract is_ssl_verification_disabled utility#1466
Open
smflorentino wants to merge 3 commits intomainfrom
Open
feat: extract is_ssl_verification_disabled utility#1466smflorentino wants to merge 3 commits intomainfrom
smflorentino wants to merge 3 commits intomainfrom
Conversation
Open
3 tasks
Extract the UIPATH_DISABLE_SSL_VERIFY check into a standalone is_ssl_verification_disabled() function so non-httpx HTTP clients can reuse the same SSL disable logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9c8bf4f to
48d03be
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UIPATH_DISABLE_SSL_VERIFYcheck fromget_httpx_client_kwargs()into a standaloneis_ssl_verification_disabled()function in_http_config.pyuipath.platform.commonTest plan
TestIsSslVerificationDisabledwith parametrized tests for truthy/falsy env var valuesTestGetHttpxClientKwargsHeaderstests still passuipath.platform.common