fix: handle null and empty array in LinearSearch (issue #7340)#7347
Merged
DenizAltunkapan merged 1 commit intoTheAlgorithms:masterfrom Mar 28, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7347 +/- ##
=========================================
Coverage 79.45% 79.46%
- Complexity 7083 7084 +1
=========================================
Files 790 790
Lines 23164 23166 +2
Branches 4556 4557 +1
=========================================
+ Hits 18405 18408 +3
+ Misses 4022 4021 -1
Partials 737 737 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #7340 - LinearSearch does not explicitly handle null or empty arrays, which can cause unexpected NullPointerExceptions or incorrect behavior.
Changes
find()methodarray.length == 0)-1for null/empty input, consistent with BinarySearch behaviorBehavior
nullarray-1[]-1(loop never runs)-1(explicit)-1This is consistent with how
BinarySearchhandles null/empty input.Fixes #7340