grt: refactor FastRouteCore files#9785
grt: refactor FastRouteCore files#9785eder-matheus merged 8 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ROAD into grt_refactor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a series of refactoring changes across multiple files in the FastRouteCore. The main changes include removing duplicated code by introducing lambda functions and a helper function, replacing C-style casts with static_cast, and using references instead of raw pointers where applicable. These changes significantly improve code readability, maintainability, and adherence to modern C++ practices. The logic remains equivalent, and the changes do not appear to affect functionality. Overall, this is a great set of improvements to the codebase.
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
…ROAD into grt_refactor
|
@maliberty This is ready for review, and don't have any QoR impact. It's just a refactoring to make the code more readable. |
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Updates on multiple FastRouteCore files, including:
The updates should not affect any functionality.