Change 'min'/'max' to 'greater'/'less' when defining thresholds for threshold_metrics_label_units#4416
Open
ecobost wants to merge 2 commits intoSpikeInterface:mainfrom
Open
Change 'min'/'max' to 'greater'/'less' when defining thresholds for threshold_metrics_label_units#4416ecobost wants to merge 2 commits intoSpikeInterface:mainfrom
threshold_metrics_label_units#4416ecobost wants to merge 2 commits intoSpikeInterface:mainfrom
Conversation
ecobost
changed the title
threshold_metrics_label_units
ecobost
force-pushed
the
greater_less
branch
from
076a34a to
ab2a7c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #4414
I also added a check to make sure that only valid keys are accepted inside the threshold dictionaries. Currently (in main):
in this PR the second line will raise ValueError