Set num_histogram_bins in amplitude_cutoff (back) to 100#4415
Open
ecobost wants to merge 3 commits intoSpikeInterface:mainfrom
Open
Set num_histogram_bins in amplitude_cutoff (back) to 100#4415ecobost wants to merge 3 commits intoSpikeInterface:mainfrom
ecobost wants to merge 3 commits intoSpikeInterface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4353 changed the default
num_histogram_binsin AmplitudeCutoff from 100 to 200 to get a more granular histogram/estimate.spikeinterface/src/spikeinterface/metrics/quality/misc_metrics.py
Line 1034 in 797f0e8
But given the default
amplitudes_bins_min_ratio=5, any cell with less than 1000 spikes will return amplitude_cutoff = NaN. That is (I think?) too big a hurdle (a unit with 0.1Hz firing rate will require 2.8 hours to spike 1000 times).Assuming 500 spikes are enough to model the amplitude distribution, I change it back to 100 here. I also change the default value on the low-level
amplitude_cutoff()to match this default.EDIT: Even if we don't think 500 spikes are enough to model the distribution, the right parameter to change would be
amplitudes_bins_min_ratioand notnum_histogram_binsas we would rather have more samples per bin (lower variance)