Skip to content

Set num_histogram_bins in amplitude_cutoff (back) to 100#4415

Open
ecobost wants to merge 3 commits intoSpikeInterface:mainfrom
ecobost:amp_cutoff
Open

Set num_histogram_bins in amplitude_cutoff (back) to 100#4415
ecobost wants to merge 3 commits intoSpikeInterface:mainfrom
ecobost:amp_cutoff

Conversation

@ecobost
Copy link
Contributor

@ecobost ecobost commented Feb 27, 2026

#4353 changed the default num_histogram_bins in AmplitudeCutoff from 100 to 200 to get a more granular histogram/estimate.

But given the default amplitudes_bins_min_ratio=5, any cell with less than 1000 spikes will return amplitude_cutoff = NaN. That is (I think?) too big a hurdle (a unit with 0.1Hz firing rate will require 2.8 hours to spike 1000 times).

Assuming 500 spikes are enough to model the amplitude distribution, I change it back to 100 here. I also change the default value on the low-level amplitude_cutoff()to match this default.

EDIT: Even if we don't think 500 spikes are enough to model the distribution, the right parameter to change would be amplitudes_bins_min_ratio and not num_histogram_bins as we would rather have more samples per bin (lower variance)

@alejoe91 alejoe91 added the metrics Related to metrics module label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics Related to metrics module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants