Fix macos and ios builds#26
Open
Eclips4 wants to merge 5 commits intoRust-for-CPython:3.15-rust-in-cpythonfrom
Open
Fix macos and ios builds#26Eclips4 wants to merge 5 commits intoRust-for-CPython:3.15-rust-in-cpythonfrom
Eclips4 wants to merge 5 commits intoRust-for-CPython:3.15-rust-in-cpythonfrom
Conversation
Eclips4
force-pushed
the
fix-macos-and-ios-builds
branch
from
001b626 to
e91d729
Compare
Eclips4
commented
Mar 10, 2026
|
|
||
| // For iOS targets, bindgen may parse headers with an iOS simulator/device | ||
| // target but without a deployment minimum, which disables TLS support. | ||
| let deployment_target = ios_deployment_target(builddir).unwrap_or_else(|| "13.0".to_string()); |
Member
Author
There was a problem hiding this comment.
the default value here is the current target (IPHONEOS_DEPLOYMENT_TARGET)
emmatyping
approved these changes
Mar 11, 2026
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
This is great, not only fixing iOS and macOS but also improves the code. Thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.