Skip to content

Toolchain install cleanup #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Firestar99 merged 6 commits into from
Feb 10, 2026
Merged

Toolchain install cleanup #138

Firestar99 merged 6 commits into from
Feb 10, 2026
+221 −103

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Feb 10, 2026

Require #137

  • rewrite of toolchain installation
  • verify that all required components of a toolchain are installed, not just that the toolchain itself is installed. See Install Clippy for a custom toolchain if missing #136
  • use --profile minimal to not install rustfmt and rust-docs, see rustup docs
  • the toolchain install consent now defaults to yes when pressing enter

close #136

@Firestar99 Firestar99 force-pushed the toolchain-install-cleanup branch from 17b5f89 to 220abf7 Compare February 10, 2026 15:10
Base automatically changed from lint-settings to main February 10, 2026 15:31
@Firestar99 Firestar99 marked this pull request as ready for review February 10, 2026 15:31
@Firestar99 Firestar99 merged commit e87c3d7 into main Feb 10, 2026
11 checks passed
@Firestar99 Firestar99 deleted the toolchain-install-cleanup branch February 10, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tombh tombh tombh approved these changes

@eddyb eddyb Awaiting requested review from eddyb

@LegNeato LegNeato Awaiting requested review from LegNeato

@nnethercote nnethercote Awaiting requested review from nnethercote

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install Clippy for a custom toolchain if missing

2 participants

@Firestar99 @tombh