Add support for s390x (IBM Z) architecture#119
Merged
chtenb merged 4 commits intoRubjerg:masterfrom Mar 9, 2026
Merged
Conversation
Added support for s390x architecture in Rid property.
Member
|
Can you please make sure to test this change, and explain how you tested it, before I merge and release a new version? |
Uses a numeric cast for the S390x enum value to maintain compatibility with .NET Standard 2.0 while supporting newer .NET 6+ environments.
Contributor
Author
Test Environment
How I Tested
Key ImprovementBefore this PR: The package would look for binaries in After this PR: The package now correctly recognizes s390x architecture and searches |
Member
|
Since our automated tests only run against .NET 8.0, I've verified manually that this causes no runtime issues in .NET versions prior to version 6.0. |
Contributor
Author
|
Thank you @chtenb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for s390x (IBM Z) architecture
Summary
This PR adds support for s390x architecture (IBM Z/zLinux) to the Graphviz.NetWrapper library.
Problem
Currently, when running on s390x architecture, the library doesn't recognize it and falls back to "unknown", resulting in incorrect runtime identifier paths (
linux-unknowninstead oflinux-s390x).Solution
Added
Architecture.S390xcase to the architecture detection switch statement inGraphvizCommand.cs.Changes
Rubjerg.Graphviz/GraphvizCommand.csto include s390x architecture detectionCompatibility
Architecture.S390xenum value (available since .NET 6)Additional Context
Fixes #118