Open
Conversation
…l terminology** Rename `setNumThreads`/`getNumThreads` → `setParallelism`/`getParallelism` and `getThreadPoolCapacity` → `getPoolSize` across VectorSimilarity. Public info API fields (`numThreads`, `lastReservedThreads`, `NUM_THREADS`, `LAST_RESERVED_NUM_THREADS`) remain unchanged. No behavioral changes.
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
- Coverage 96.98% 96.93% -0.06%
==========================================
Files 129 129
Lines 7574 7578 +4
==========================================
Hits 7346 7346
- Misses 228 232 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1: Rename SVS thread pool internal methods to match shared pool terminology
Rename
setNumThreads/getNumThreads→setParallelism/getParallelismandgetThreadPoolCapacity→getPoolSizeacross VectorSimilarity. Public info API fields (numThreads,lastReservedThreads,NUM_THREADS,LAST_RESERVED_NUM_THREADS) remain unchanged. No behavioral changes.Describe the changes in the pull request
A clear and concise description of what the PR is solving.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Medium Risk
Mostly mechanical renaming of SVS threadpool controls, but it touches concurrency-related code paths and introduces a new public C API (
VecSim_UpdateThreadPoolSize) that changes global write mode behavior.Overview
Refactors SVS thread-management terminology by renaming internal threadpool controls from
*NumThreads/*ThreadPoolCapacityto*Parallelism/*PoolSizeacross SVS and tiered-SVS code, while keeping the external debug/info fields (numThreads,lastReservedThreads) unchanged.Adds scaffolding for a shared SVS thread pool:
SVSIndexBase::getSharedThreadPool()singleton accessor and a new public C APIVecSim_UpdateThreadPoolSize()(currently only toggles async vs in-place write mode, with a TODO to create/resize the shared pool). Tests/benchmarks are updated to use the new method names.Written by Cursor Bugbot for commit c488bf0. This will update automatically on new commits. Configure here.