Skip to content

Fix duplicate OAuth token requests #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JosueNina wants to merge 4 commits into from
Closed

Fix duplicate OAuth token requests #626

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d2f24d
Prevent duplicate token requests
JosueNina Feb 6, 2026
a176811
Solve review comments
JosueNina Feb 6, 2026
91a4728
Cache only what is necessary
JosueNina Feb 6, 2026
0068adc
Minor fix
JosueNina Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions lean/models/json_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,17 +235,28 @@ def config_build(self,
logger.debug(f"skipping configuration '{configuration._id}': no choices available.")
continue
elif isinstance(configuration, AuthConfiguration):
lean_config["project-id"] = self.get_project_id(lean_config["project-id"],
configuration.require_project_id)
logger.debug(f'project_id: {lean_config["project-id"]}')
auth_authorizations = get_authorization(container.api_client.auth0, self._display_name.lower(),
logger, lean_config["project-id"], no_browser=no_browser)
logger.debug(f'auth: {auth_authorizations}')
configuration._value = auth_authorizations.get_authorization_config_without_account()
# Create a unique cache key based on brokerage + project_id
cache_key = f"{self._display_name.lower()}_{lean_config.get('project-id', 0)}"

if cache_key not in lean_config:
# Only get the token if it's not in the cache
lean_config["project-id"] = self.get_project_id(lean_config["project-id"],
configuration.require_project_id)
logger.debug(f'project_id: {lean_config["project-id"]}')
auth_authorizations = get_authorization(container.api_client.auth0, self._display_name.lower(),
logger, lean_config["project-id"], no_browser=no_browser)
logger.debug(f'auth: {auth_authorizations}')
lean_config[cache_key] = {
"config": auth_authorizations.get_authorization_config_without_account(),
"account_ids": auth_authorizations.get_account_ids()
}

cached_auth = lean_config[cache_key]
configuration._value = cached_auth["config"]
for inner_config in self._lean_configs:
if any(condition._dependent_config_id == configuration._id for condition in
inner_config._filter._conditions):
api_account_ids = auth_authorizations.get_account_ids()
api_account_ids = cached_auth["account_ids"]
config_dash = inner_config._id.replace('-', '_')
inner_config._choices = api_account_ids
if user_provided_options and config_dash in user_provided_options:
Expand Down
Loading