Timeless Jewel trade search should default to "instant buyout only"#9671
Open
james-dum wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Timeless Jewel trade search should default to "instant buyout only"#9671james-dum wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
james-dum wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When searching for timeless jewels via the "Find Timeless Jewel" button, the trade site URLs default to "instant buyout and in person."
This behavior is not desirable because many sellers of timeless jewels purposely list the jewels in a dump tab for a cheap price that they're not actually willing to sell at, because they want to use the community to give them a free price check.
This is especially a problem during league start, or when you're searching for an unpopular or non-meta jewel. The vast majority of the listings will be from sellers who are just looking to get a zero-effort price check, and if you DM them asking to buy the jewel, they will just ignore you and relist it for a higher price.
Steps taken to verify a working solution:
Ran the code locally and confirmed that the generated trade URLs work as expected, and are set to "instant buyout only."
Link to a build that showcases this PR:
Before screenshot:
After screenshot: