Skip to content

[clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191)#192

Open
Seb-MIGUEL wants to merge 1 commit intomainfrom
191-add-new-contractoutputtype
Open

[clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191)#192
Seb-MIGUEL wants to merge 1 commit intomainfrom
191-add-new-contractoutputtype

Conversation

@Seb-MIGUEL
Copy link

Summary

  • Add 13 new ContractOutputType enum values to support structured finding extraction beyond text and credentials
  • New types: Username, Share, AdminUsername, Group, Computer, PasswordPolicy, Delegation, Sid, Vulnerability, AccountWithPasswordNotRequired, AsreproastableAccount, KerberoastableAccount
  • These allow injectors to produce domain-specific findings instead of generic text output

Rationale

  • Credentials should only represent reusable secrets (passwords, NTLM hashes, Kerberos keys)
  • Kerberoasting/AS-REP roasting hashes are crackable material, not directly reusable credentials — they now have their own finding types
  • Enumeration results (users, groups, shares, etc.) deserve specific types for proper filtering, display, and aggregation in the platform
  • Vulnerability detections (Spooler enabled, LDAP signing not enforced, etc.) need a dedicated type separate from generic text

Backward Compatibility

No existing enum values were removed or renamed. This is purely additive.

Closes #191

  Add 13 new enum values (Credentials, Username, Share, AdminUsername,
  Group, Computer, PasswordPolicy, Delegation, Sid, Vulnerability,
  AccountWithPasswordNotRequired, AsreproastableAccount,
  KerberoastableAccount) to support domain-specific finding extraction.

  Closes #191
@Seb-MIGUEL Seb-MIGUEL linked an issue Mar 5, 2026 that may be closed by this pull request
@Seb-MIGUEL Seb-MIGUEL changed the title feat: add new ContractOutputType values for structured findings [client] feat: add new ContractOutputType values for structured findings Mar 5, 2026
@Seb-MIGUEL Seb-MIGUEL changed the title [client] feat: add new ContractOutputType values for structured findings [client-python] feat: add new ContractOutputType values for structured findings Mar 5, 2026
@ncarenton ncarenton requested a review from mariot March 5, 2026 10:52
@mariot mariot changed the title [client-python] feat: add new ContractOutputType values for structured findings [client-python] feat(contracts): add new ContractOutputType values for structured findings (#191) Mar 5, 2026
@mariot mariot changed the title [client-python] feat(contracts): add new ContractOutputType values for structured findings (#191) [clientpython] feat(contracts): add new ContractOutputType values for structured findings (#191) Mar 5, 2026
@ncarenton ncarenton self-requested a review March 5, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add New contractoutputtype

3 participants