-
Notifications
You must be signed in to change notification settings - Fork 475
fix(gpu): add Tegra/Jetson GPU support #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elezar
wants to merge
10
commits into
main
Choose a base branch
from
fix/tegra-gpu-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7b82b68
fix(gpu): add Tegra host-files bind-mount
elezar 2b0f4d7
fix(gpu): pin device plugin to development image
elezar 8716adc
fix(sandbox): preserve CDI-injected GIDs across privilege drop
elezar d39c1bc
test(e2e): fall back to /usr/sbin/nvidia-smi on Tegra
elezar 2c06aad
Merge remote-tracking branch 'origin/main' into fix/tegra-gpu-support
pimlock 730d104
fix(gpu): gate Tegra-specific runtime adjustments
pimlock ccb6654
Revert "fix(gpu): gate Tegra-specific runtime adjustments"
pimlock 4eccf31
Merge remote-tracking branch 'origin/main' into fix/tegra-gpu-support
pimlock 168a901
fix(bootstrap): detect Tegra via Docker API and bump container toolkit
pimlock 5d21ac3
fix(bootstrap,sandbox): add Tegra detection logging and extract CDI G…
pimlock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elezar some context on this change: the previous version checking if that file exists wouldn't work for remote deployments, as the file would be checked against local file system and not the remote one.
By default, the gateways starts on the local system, but it can be deployed remotely with a command like this.
In this case, the CLI is installed on my Mac and the gateway is deployed over SSH on the
remote-host.This approach will work for local and remote deployments, and is based on the kernel version including
tegra, as at this point we don't have access to the filesystem on the remote host. We could add something like this, but it would be a bigger change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also was wondering if it would make sense to include that path
/etc/nvidia-container-runtime/host-files-for-container.din the CDI that is generated on that host? Could the container toolkit running on Tegra (or other systems that need these CSVs) add that mount to the CDI spec? Then, this manual mount wouldn't be necessary.