-
Notifications
You must be signed in to change notification settings - Fork 326
Add experimental support for transformers>=5.0 + min torch 2.8 + bug fixes for tests #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevalmorabia97
wants to merge
23
commits into
main
Choose a base branch
from
kmorabi/bump-transformers-5.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+593
−432
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2401210
Bump transformers to 5.0
kevalmorabia97 b269824
Fix Bert Gradnas tracing for transformers 5.0
kevalmorabia97 66ec553
Add more fixes
kevalmorabia97 bdaa515
Fix Bert and DBRX unit tests
kevalmorabia97 c72454c
Fix transformers load and test_llm_qat
kevalmorabia97 46348a0
Remove tokenizer.batch_encode_plus
kevalmorabia97 1d9155b
Remove deprecated transformers arguments
kevalmorabia97 ee51fd7
Rename torch_dtype to dtype
kevalmorabia97 aa6c3ce
Remove hard-coded trust_remote_code=True
kevalmorabia97 7343c4f
Fix unit tests
kevalmorabia97 31efc36
Enable some quantizer manual tests
kevalmorabia97 f69d9fa
fix test
kevalmorabia97 2dc3140
Set min transformers 5.0
kevalmorabia97 b37545b
Fix more tests
kevalmorabia97 1024528
Fix for TRT-LLM
kevalmorabia97 1e45639
Let PTQ example tests run with transformers<5.0
kevalmorabia97 38e26e3
fix tests
kevalmorabia97 26cf04a
minor fixes
kevalmorabia97 6d3af7c
Remove transformers 5.0 compatibility patch for trtllm; disable MOE c…
kevalmorabia97 f707ce5
fix for cppimport container test
kevalmorabia97 d5b61cb
Fix spec dec example tests
kevalmorabia97 22e9d4d
minor
kevalmorabia97 fdeb1ab
Add back windows accuracy_benchmark dependencies + trust_remote_code fix
kevalmorabia97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| kernels>=0.9.0 | ||
| torch>2.7.1 | ||
| trackio | ||
| transformers>=4.55.0 | ||
kevalmorabia97 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| trl>=0.21.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| pyarrow | ||
| torchao>=0.14.1 | ||
| transformers<5.0 | ||
| trl>=0.23.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes related to the transformers + torch upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec dec tests were silently skipped because dataset setup logic was recently changed. With new logic after fixing those tests, this is no longer needed