Refactoring of storage + rename detection#3
Open
alansingfield wants to merge 26 commits intoMisinformedDNA:masterfrom
Open
Refactoring of storage + rename detection#3alansingfield wants to merge 26 commits intoMisinformedDNA:masterfrom
alansingfield wants to merge 26 commits intoMisinformedDNA:masterfrom
Conversation
…- think deserves a better format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS WORK IS NOT FINISHED!!!
Added Rename detection - this works by matching on lastmodified date/time and length. If it sees a delete and a create together which are either (same directory, different name) or (same name, different directory) - it discards the delete and create, putting a Rename in place.
Work on memory usage. There were a lot of strings being allocated for the filenames and directory names, meaning high memory usage when monitoring large folders.
Implemented a Parent Pointer Tree to store each directory name only once.