Skip to content

chore: Expose KeyringController:signTransaction through messenger#8408

Merged
Mrtenz merged 2 commits intomainfrom
mrtenz/keyring-controller-sign-transaction
Apr 8, 2026
Merged

chore: Expose KeyringController:signTransaction through messenger#8408
Mrtenz merged 2 commits intomainfrom
mrtenz/keyring-controller-sign-transaction

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Apr 8, 2026

Explanation

This adds KeyringController:signTransaction to MESSENGER_EXPOSED_METHODS and exports the type, as this was missed in #8391.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Expands the controller’s messenger API to allow remote callers to request transaction signatures, which is security-sensitive despite being a small change. Risk is mainly around new call surface/permissions and ensuring consumers handle the new action correctly.

Overview
Enables KeyringController:signTransaction to be invoked through the KeyringController messenger by adding it to the exposed method allowlist.

Adds and exports the corresponding KeyringControllerSignTransactionAction type (and updates the method-action union), and records the new messenger exposure in the package changelog.

Reviewed by Cursor Bugbot for commit 497b413. Bugbot is set up for automated code reviews on this repo. Configure here.

@Mrtenz Mrtenz marked this pull request as ready for review April 8, 2026 13:55
@Mrtenz Mrtenz requested review from a team as code owners April 8, 2026 13:55
@Mrtenz Mrtenz added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit b97feef Apr 8, 2026
341 checks passed
@Mrtenz Mrtenz deleted the mrtenz/keyring-controller-sign-transaction branch April 8, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants