chore: Expose KeyringController:signTransaction through messenger#8408
Merged
chore: Expose KeyringController:signTransaction through messenger#8408
KeyringController:signTransaction through messenger#8408Conversation
FrederikBolding
approved these changes
Apr 8, 2026
ccharly
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This adds
KeyringController:signTransactiontoMESSENGER_EXPOSED_METHODSand exports the type, as this was missed in #8391.References
Checklist
Note
Medium Risk
Expands the controller’s messenger API to allow remote callers to request transaction signatures, which is security-sensitive despite being a small change. Risk is mainly around new call surface/permissions and ensuring consumers handle the new action correctly.
Overview
Enables
KeyringController:signTransactionto be invoked through theKeyringControllermessenger by adding it to the exposed method allowlist.Adds and exports the corresponding
KeyringControllerSignTransactionActiontype (and updates the method-action union), and records the new messenger exposure in the package changelog.Reviewed by Cursor Bugbot for commit 497b413. Bugbot is set up for automated code reviews on this repo. Configure here.