Skip to content

Ensure refs in tsconfig files are synced with internal deps #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcmire wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Ensure refs in tsconfig files are synced with internal deps #8384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6cb4611
Ensure refs in tsconfig files are synced with internal deps
mcmire Feb 26, 2026
5a85c1c
When appending new references, preserve order even in the case of a n…
mcmire Apr 6, 2026
a0fe302
Normalise -> normalize
mcmire Apr 6, 2026
783f7e5
Remove old JSDoc
mcmire Apr 6, 2026
4e56c94
Minor tweaks
mcmire Apr 6, 2026
fa6349c
Fix eip-5792-middleware to add missing dependency
mcmire Apr 6, 2026
563913f
Remove circular dependency between network-controller and eth-json-rp…
mcmire Apr 6, 2026
464d1bc
Fix keyring-controller to add missing dependency
mcmire Apr 6, 2026
7d12bc9
Remove needless ts-expect-error
mcmire Apr 6, 2026
56f2779
Fix lint violation
mcmire Apr 6, 2026
03f4104
Correct changelog
mcmire Apr 6, 2026
6236cfc
Update lockfile
mcmire Apr 6, 2026
5b487e7
Update README
mcmire Apr 6, 2026
f6f4a91
Fix missing comma
mcmire Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/lint-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- lint:teams
- messenger-action-types:check
- readme-content:check
- lint:tsconfigs:all
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ linkStyle default opacity:0.5
earn_controller --> network_controller;
earn_controller --> transaction_controller;
eip_5792_middleware --> messenger;
eip_5792_middleware --> preferences_controller;
eip_5792_middleware --> transaction_controller;
eip_5792_middleware --> keyring_controller;
eip_7702_internal_rpc_middleware --> controller_utils;
Expand All @@ -329,7 +330,6 @@ linkStyle default opacity:0.5
eth_json_rpc_middleware --> eth_json_rpc_provider;
eth_json_rpc_middleware --> json_rpc_engine;
eth_json_rpc_middleware --> message_manager;
eth_json_rpc_middleware --> network_controller;
eth_json_rpc_provider --> json_rpc_engine;
gas_fee_controller --> base_controller;
gas_fee_controller --> controller_utils;
Expand All @@ -344,6 +344,7 @@ linkStyle default opacity:0.5
geolocation_controller --> messenger;
json_rpc_middleware_stream --> json_rpc_engine;
keyring_controller --> base_controller;
keyring_controller --> controller_utils;
keyring_controller --> messenger;
logging_controller --> base_controller;
logging_controller --> controller_utils;
Expand Down
3 changes: 1 addition & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ const config = createConfig([
'**/*.test.{js,ts}',
'**/test/**/*.{js,ts}',
'**/tests/**/*.{js,ts}',
'scripts/*.ts',
'scripts/create-package/**/*.ts',
'scripts/**/*.ts',
Copy link
Copy Markdown
Contributor Author

@mcmire mcmire Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've added a new subdirectory to scripts so rather than adding an extra entry here we can consolidate them all into one glob.

],
extends: [nodejs],
},
Expand Down
8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,18 @@
"changelog:update": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:update",
"changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",
"create-package": "tsx scripts/create-package",
"lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check",
"lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check && yarn lint:tsconfigs:all",
"lint:dependencies": "depcheck && yarn dedupe --check",
"lint:dependencies:fix": "depcheck && yarn dedupe",
"lint:eslint": "yarn build:only-clean && NODE_OPTIONS='--max-old-space-size=6144' yarn eslint",
"lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn messenger-action-types:generate && yarn readme-content:update",
"lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn messenger-action-types:generate && yarn readme-content:update && yarn lint:tsconfigs:fix:all",
"lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
"lint:misc:check": "yarn lint:misc --check",
"lint:teams": "tsx scripts/lint-teams-json.ts",
"lint:tsconfigs": "tsx scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs",
"lint:tsconfigs:fix": "tsx scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"lint:tsconfigs:fix:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs:fix",
"messenger-action-types:check": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:check",
"messenger-action-types:generate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:generate",
"prepack": "./scripts/prepack.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/account-tree-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/account-tree-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/account-tree-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
24 changes: 18 additions & 6 deletions packages/account-tree-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,24 @@
"rootDir": "./src"
},
"references": [
{ "path": "../accounts-controller/tsconfig.build.json" },
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../keyring-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" },
{ "path": "../multichain-account-service/tsconfig.build.json" },
{ "path": "../profile-sync-controller/tsconfig.build.json" }
{
"path": "../accounts-controller/tsconfig.build.json"
},
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../keyring-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
},
{
"path": "../multichain-account-service/tsconfig.build.json"
},
{
"path": "../profile-sync-controller/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
2 changes: 2 additions & 0 deletions packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/accounts-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/accounts-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
15 changes: 12 additions & 3 deletions packages/accounts-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,18 @@
{
"path": "../base-controller/tsconfig.build.json"
},
{ "path": "../keyring-controller/tsconfig.build.json" },
{ "path": "../network-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../keyring-controller/tsconfig.build.json"
},
{
"path": "../network-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
},
{
"path": "../controller-utils/tsconfig.build.json"
Copy link
Copy Markdown
Contributor Author

@mcmire mcmire Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is present in devDependencies but was missing as a reference.

}
],
"include": ["../../types", "./src"]
}
11 changes: 9 additions & 2 deletions packages/accounts-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,15 @@
{
"path": "../keyring-controller"
},
{ "path": "../network-controller" },
{ "path": "../messenger" }
{
"path": "../network-controller"
},
{
"path": "../messenger"
},
{
"path": "../controller-utils"
Copy link
Copy Markdown
Contributor Author

@mcmire mcmire Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is present in devDependencies but was missing as a reference.

}
],
"include": ["../../types", "./src", "./tests"]
}
2 changes: 2 additions & 0 deletions packages/address-book-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/address-book-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/address-book-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
12 changes: 9 additions & 3 deletions packages/address-book-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@
"rootDir": "./src"
},
"references": [
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../controller-utils/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../controller-utils/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
12 changes: 9 additions & 3 deletions packages/address-book-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
"baseUrl": "./"
},
"references": [
{ "path": "../base-controller" },
{ "path": "../controller-utils" },
{ "path": "../messenger" }
{
"path": "../base-controller"
},
{
"path": "../controller-utils"
},
{
"path": "../messenger"
}
],
"include": ["../../types", "./src"]
}
3 changes: 3 additions & 0 deletions packages/ai-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/ai-controllers",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/ai-controllers",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -59,6 +61,7 @@
"deepmerge": "^4.2.2",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"tsx": "^4.20.5",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.3.3"
Expand Down
8 changes: 6 additions & 2 deletions packages/ai-controllers/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
"rootDir": "./src"
},
"references": [
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
9 changes: 8 additions & 1 deletion packages/ai-controllers/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
"compilerOptions": {
"baseUrl": "./"
},
"references": [{ "path": "../base-controller" }, { "path": "../messenger" }],
"references": [
{
"path": "../base-controller"
},
{
"path": "../messenger"
}
],
"include": ["../../types", "./src"]
}
2 changes: 2 additions & 0 deletions packages/analytics-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
8 changes: 6 additions & 2 deletions packages/analytics-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
"rootDir": "./src"
},
"references": [
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
9 changes: 8 additions & 1 deletion packages/analytics-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
"compilerOptions": {
"baseUrl": "./"
},
"references": [{ "path": "../base-controller" }, { "path": "../messenger" }],
"references": [
{
"path": "../base-controller"
},
{
"path": "../messenger"
}
],
"include": ["../../types", "./src"]
}
2 changes: 2 additions & 0 deletions packages/analytics-data-regulation-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-data-regulation-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-data-regulation-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
12 changes: 9 additions & 3 deletions packages/analytics-data-regulation-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@
"rootDir": "./src"
},
"references": [
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../controller-utils/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../controller-utils/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
12 changes: 9 additions & 3 deletions packages/analytics-data-regulation-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
"baseUrl": "./"
},
"references": [
{ "path": "../base-controller" },
{ "path": "../controller-utils" },
{ "path": "../messenger" }
{
"path": "../base-controller"
},
{
"path": "../controller-utils"
},
{
"path": "../messenger"
}
],
"include": ["../../types", "./src"]
}
2 changes: 2 additions & 0 deletions packages/announcement-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/announcement-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/announcement-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
8 changes: 6 additions & 2 deletions packages/announcement-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
"rootDir": "./src"
},
"references": [
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
}
],
"include": ["../../types", "./src"]
}
9 changes: 8 additions & 1 deletion packages/announcement-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
"compilerOptions": {
"baseUrl": "./"
},
"references": [{ "path": "../base-controller" }, { "path": "../messenger" }],
"references": [
{
"path": "../base-controller"
},
{
"path": "../messenger"
}
],
"include": ["../../types", "./src"]
}
3 changes: 3 additions & 0 deletions packages/app-metadata-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/app-metadata-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/app-metadata-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -57,6 +59,7 @@
"deepmerge": "^4.2.2",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"tsx": "^4.20.5",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.3.3"
Expand Down
Loading
Loading