Skip to content

perf: Add accountIdByAddress to AccountsController state #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmalik88 merged 58 commits into from
Mar 5, 2026
+405 −6
Merged

perf: Add accountIdByAddress to AccountsController state #7893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
8c3c673
test: update tests with new controller state
hmalik88 Feb 10, 2026
9b006a5
chore: add new state to strict state typing
hmalik88 Feb 10, 2026
5238f32
feat: add getAccountIdByAddress mapping and update getAccountByAddres…
hmalik88 Feb 10, 2026
665ca3b
chore: update changelog
hmalik88 Feb 10, 2026
9097c69
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 10, 2026
56edc9c
fix: address bugbot comments
hmalik88 Feb 10, 2026
67be1db
fix: lint fix
hmalik88 Feb 10, 2026
a08cf5b
fix: update test
hmalik88 Feb 10, 2026
263f1d7
fix: fix test
hmalik88 Feb 10, 2026
b5e251d
refactor: change accountIdByAddress to not be persisted
hmalik88 Feb 10, 2026
b76f861
fix: address bugbot comment
hmalik88 Feb 10, 2026
4fbd0b0
fix: fix profilemetricscontroller test
hmalik88 Feb 10, 2026
0dd1904
fix: lint fix
hmalik88 Feb 10, 2026
45f7c30
fix: rehydrate accountIdByAddress in constructor
hmalik88 Feb 10, 2026
7991aeb
fix: update token selectors test
hmalik88 Feb 10, 2026
9764f02
fix: make test consistent with actual behavior
hmalik88 Feb 10, 2026
00a1a4a
fix: fix test
hmalik88 Feb 10, 2026
c573242
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 11, 2026
6f6b805
fix: fix test
hmalik88 Feb 11, 2026
b4e1d52
fix: fix test
hmalik88 Feb 11, 2026
dd8ae7d
fix: update test
hmalik88 Feb 11, 2026
27e39dd
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 11, 2026
6dbb30f
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 16, 2026
e209779
refactor: move accountIdByAddress logic into util
hmalik88 Feb 16, 2026
ceb8b26
fix: lint fix
hmalik88 Feb 16, 2026
8fe38b8
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 19, 2026
d94ceb0
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 20, 2026
68d4694
chore: update changelog
hmalik88 Feb 20, 2026
2e043f7
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 23, 2026
82679ae
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 23, 2026
c2f8e26
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 24, 2026
79ad9c8
fix: update import
hmalik88 Feb 24, 2026
394a945
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 24, 2026
b51eceb
fix: update import type
hmalik88 Feb 24, 2026
3da33e7
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 27, 2026
ba4003f
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 27, 2026
2d679f2
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Feb 27, 2026
7cbd791
refactor: use util to create accountIdByAddress in updateAccounts
hmalik88 Feb 27, 2026
c52e92d
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 2, 2026
cf14276
refactor: remove toLowerCase
hmalik88 Mar 2, 2026
b2b2c8f
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 2, 2026
22ff1f0
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 3, 2026
d69804a
fix: account for empty state
hmalik88 Mar 3, 2026
fa69cc0
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 3, 2026
0eb2810
test: add tests to fix coverage
hmalik88 Mar 3, 2026
564fb85
refactor: add fallback cache lookup
hmalik88 Mar 4, 2026
968b2b4
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 4, 2026
851b407
fix: revert token selector test change
hmalik88 Mar 4, 2026
8010515
refactor: change var name
hmalik88 Mar 4, 2026
ba5c672
refactor: update type to be narrower
hmalik88 Mar 4, 2026
87a960c
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 4, 2026
e40ab9e
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 5, 2026
ebcfd98
refactor: add logging for cache miss
hmalik88 Mar 5, 2026
b185e88
refactor: update logic
hmalik88 Mar 5, 2026
b132a1e
test: add test
hmalik88 Mar 5, 2026
c0380f9
fix: lint fix
hmalik88 Mar 5, 2026
2c7a6ea
refactor: apply code review
hmalik88 Mar 5, 2026
903ebe3
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/accounts-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Add `accountIdByAddress` mapping to state ([#7893](https://github.com/MetaMask/core/pull/7893))
- This state was added to improve lookup times for an account by address from O(n) to O(1).
- `getAccountByAddress` also leverages this new map, thus, should be slightly faster too.
- Add logging capabilities ([#8118](https://github.com/MetaMask/core/pull/8118/))
- Expose missing public `AccountsController` methods through its messenger ([#7976](https://github.com/MetaMask/core/pull/7976/))
- The following actions are now available:
Expand Down
Loading
Loading