Skip to content

fix: Bypasses WASM add_with_plutus_witness bug for RegisterStake cert…#813

Open
Temasar1 wants to merge 1 commit intomainfrom
fxi/wasm-register-stake
Open

fix: Bypasses WASM add_with_plutus_witness bug for RegisterStake cert…#813
Temasar1 wants to merge 1 commit intomainfrom
fxi/wasm-register-stake

Conversation

@Temasar1
Copy link
Member

@Temasar1 Temasar1 commented Mar 20, 2026

Thank you for contributing to Mesh! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.

This PR Bypasses WASM add_with_plutus_witness bug for RegisterStake certificates.

Under the hood in sidan-lab/whisky (core_csl.rs), the add_cert() method unconditionally passes all ScriptCertificate objects to add_with_plutus_witness(). Because RegisterStake lacks a script witness natively, this triggers:

[Error - CoreCSL - add_cert - add_with_plutus_witness]: Your certificate does not have a required script witness. Please use .add instead.

Remember to follow our Contributing Guide before submitting your pull request.

Summary

Please provide a brief, concise summary of the changes in your pull request. Explain the problem you are trying to solve and the solution you have implemented.

This safely forces the WebAssembly logic to fall into the Certificate::BasicCertificate matching, bypassing the witness validation check exactly as intended and resolving the transaction generation crash securely.

Affect components

Please indicate which part of the Mesh Repo

  • @meshsdk/common
  • @meshsdk/contract
  • @meshsdk/core
  • [✅ ] @meshsdk/core-csl
  • @meshsdk/core-cst
  • @meshsdk/hydra
  • @meshsdk/provider
  • @meshsdk/react
  • @meshsdk/svelte
  • @meshsdk/transaction
  • @meshsdk/wallet
  • Mesh playground (i.e. https://meshjs.dev/)
  • Mesh CLI

Type of Change

Please mark the relevant option(s) for your pull request:

  • [ ✅] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [✅ ] Bug fix (non-breaking change which fixes an issue)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Related Issues

Please add the related issue here if any

Checklist

Please ensure that your pull request meets the following criteria:

  • [✅ ] My code is appropriately commented and includes relevant documentation, if necessary
  • [ ✅] I have added tests to cover my changes, if necessary
  • I have updated the documentation, if necessary
  • [ ✅] All new and existing tests pass (i.e. npm run test)
  • The build is pass (i.e. npm run build)

Additional Information

If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

@Temasar1 Temasar1 requested a review from HinsonSIDAN March 20, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant