PLUG-22 Fixed Request Timout #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
gabrielLarsSabadin
approved these changes
Feb 10, 2026
aloisklink
approved these changes
Feb 10, 2026
Contributor
aloisklink
left a comment
aloisklink
left a comment
There was a problem hiding this comment.
@Prashant-7718, can you also add an [UNRELEASED] section to the packages/sdk/CHANGELOG.md file and describe this change there?
At least until we've switched over to something like changesets, it will mean that we at least have one way to tell consumers of the @mermaidchart/sdk what changes and improvements are in each release.
Other than that, thanks for fixing the CI!
packages/sdk/src/index.e2e.test.ts
Outdated
| if (!testProjectId) { | ||
| throw new Error( | ||
| 'Missing required environment variable TEST_MERMAIDCHART_PROJECT_ID. ' + | ||
| `Please go to ${new URL('/app/projects', baseURL)} and create one Project.`, |
Contributor
There was a problem hiding this comment.
nitpick: Just a small grammar fix.
Suggested change
| `Please go to ${new URL('/app/projects', baseURL)} and create one Project.`, | |
| `Please go to ${new URL('/app/projects', baseURL)} and create a project.`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but important change to the initialization order in the MermaidChart class constructor. It ensures that the requestTimeout property is set before calling setBaseURL, so the Axios instance is created with the correct timeout configuration.
It also improves the reliability and configurability of the SDK’s end-to-end (E2E) tests by moving test-specific settings to environment variables.
Changes included:
Updated the initialization order in the MermaidChart constructor so requestTimeout is set before invoking setBaseURL, ensuring the Axios client uses the correct timeout.
Improved the E2E test workflow by passing TEST_MERMAIDCHART_PROJECT_ID and TEST_MERMAIDCHART_BASE_URL via environment variables, making the tests more flexible and secure.