Fix[2290] - Fix overeager lambda function parsing#2293
Merged
manticore-projects merged 1 commit intoJSQLParser:masterfrom Aug 11, 2025
Merged
Fix[2290] - Fix overeager lambda function parsing#2293manticore-projects merged 1 commit intoJSQLParser:masterfrom
manticore-projects merged 1 commit intoJSQLParser:masterfrom
Conversation
`SELECT DATE_TRUNC('week',("schema"."tbl"."column" + INTERVAL '1 day')) FROM "schema"."tbl";`
is parsing the `("schema"."tbl"."column" + INTERVAL '1 day')` as a LambdaFunction incorrectly, and crashes out. Increasing the lookahead depth by 1 ensures it fails to match on the `->` keyword (I believe), and falls into a simple expression instead.
JMH
```
jmh {
includes = ['.*JSQLParserBenchmark.*']
warmupIterations = 2
fork = 5
iterations = 5
timeOnIteration = '5s'
}
```
After:
```
33.970 ±(99.9%) 1.773 ms/op [Average]
(min, avg, max) = (31.405, 33.970, 37.302), stdev = 2.367
CI (99.9%): [32.197, 35.743] (assumes normal distribution)
```
Before:
```
34.882 ±(99.9%) 1.923 ms/op [Average]
(min, avg, max) = (31.191, 34.882, 37.406), stdev = 2.567
CI (99.9%): [32.959, 36.805] (assumes normal distribution)
```
Contributor
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT DATE_TRUNC('week',("schema"."tbl"."column" + INTERVAL '1 day')) FROM "schema"."tbl";is parsing the("schema"."tbl"."column" + INTERVAL '1 day')as a LambdaFunction incorrectly, and crashes out. Increasing the lookahead depth by 1 ensures it fails to match on the->keyword (I believe), and falls into a simple expression instead.Fixes #2290
JMH
After:
Before: