Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the codebase to PHP CodeSniffer 4, along with updating PHP version requirements and improving the MeaningfulVariableNameSniff with healthy defaults.
- Upgraded PHP CodeSniffer from ^3.13 to ^4.0 and updated related dependencies
- Added default forbidden variable names to MeaningfulVariableNameSniff for better code quality
- Created custom helper classes extending SlevomatCodingStandard helpers for internal API consistency
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP version to ^8.3, upgraded PHPCS to v4 and related dependencies |
| IxDFCodingStandard/Sniffs/NamingConventions/MeaningfulVariableNameSniff.php | Added default forbidden variable names array with type-like names |
| IxDFCodingStandard/Sniffs/Laravel/RequireCustomAbortMessageSniff.php | Updated phpcs:ignore comments for PHPCS 4 compatibility |
| IxDFCodingStandard/Sniffs/Laravel/NonExistingBladeTemplateSniff.php | Updated phpcs:ignore comments for PHPCS 4 compatibility |
| IxDFCodingStandard/Sniffs/Laravel/DisallowGuardedAttributeSniff.php | Switched to custom ClassHelper from SlevomatCodingStandard |
| IxDFCodingStandard/Sniffs/Laravel/BladeTemplateExtractor.php | Removed unnecessary string casts and added phpcs disable comment |
| IxDFCodingStandard/Sniffs/Functions/MissingOptionalArgumentSniff.php | Updated to use custom TokenHelper and new constant name |
| IxDFCodingStandard/Sniffs/Classes/ForbidMethodDeclarationSniff.php | Switched to custom ClassHelper from SlevomatCodingStandard |
| IxDFCodingStandard/Helpers/TokenHelper.php | New custom helper extending SlevomatCodingStandard TokenHelper |
| IxDFCodingStandard/Helpers/ClassHelper.php | New custom helper extending SlevomatCodingStandard ClassHelper |
| .github/workflows/validator.yml | Updated PHP version from 8.2 to 8.4 |
| .github/workflows/test.yml | Updated test matrix to include PHP 8.3, 8.4, 8.5 and removed 8.2 |
| .github/workflows/psalm.yml | Updated PHP version from 8.2 to 8.4 |
| .github/workflows/format_php.yml | Updated PHP version from 8.2 to 8.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus: